Replace nowide with C++17 filesystem#1981
Draft
IsaacMarovitz wants to merge 1 commit intoflyinghead:devfrom
Draft
Replace nowide with C++17 filesystem#1981IsaacMarovitz wants to merge 1 commit intoflyinghead:devfrom
IsaacMarovitz wants to merge 1 commit intoflyinghead:devfrom
Conversation
Signed-off-by: Isaac Marovitz <isaacryu@icloud.com>
Owner
|
c++17 filesystem uses UTF-8 on UTF-8 platforms but uses the local code page on windows. In order to use UTF-8, you need to use special std::fs constructs and methods ( So I think we need some convenience classes/functions to handle these conversions properly (and c++20-compatble) and avoid errors in the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flycast has very many dependencies, some of which have been superseded by better or more standardised implementations.
C++17 filesystem has support for UTF-8 API functions more or less removing the need for nowide here and cutting out one dependency.