Skip to content

MODEXPW-629 Make instance-authority-links-statistics interface optional#734

Merged
psmagin merged 1 commit intomasterfrom
MODEXPW-629
Apr 9, 2026
Merged

MODEXPW-629 Make instance-authority-links-statistics interface optional#734
psmagin merged 1 commit intomasterfrom
MODEXPW-629

Conversation

@psmagin
Copy link
Copy Markdown
Contributor

@psmagin psmagin commented Apr 9, 2026

Purpose

Make instance-authority-links-statistics interface optional

Approach

TODOS and Open Questions

Learning

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • Check logging
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • Were any API paths or methods changed, added or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added, or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@psmagin psmagin requested review from a team, SvitlanaKovalova1 and viacheslavkol and removed request for a team April 9, 2026 10:49
@psmagin psmagin self-assigned this Apr 9, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 9, 2026

@psmagin psmagin merged commit 3084337 into master Apr 9, 2026
16 checks passed
@psmagin psmagin deleted the MODEXPW-629 branch April 9, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants