Repository navigation
chore(wallets): drop the time crate pin - #246
Merged
Merged
Conversation
aws-smithy-types 1.5.0 failed to compile with time 0.3.48, so the aws-kms feature pinned time to 0.3.47. The resolved aws-smithy-types 1.6.1 compiles with time 0.3.55 on Rust 1.98, and the exact pin now blocks any workspace that depends on foundry-wallets and on a crate that needs time 0.3.51 or newer, such as reth-node-core through vergen.
figtracer
marked this pull request as ready for review
October 6, 2026 16:46
figtracer
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mablr,
mattsse,
onbjerg and
stevencartavia
as code owners
October 6, 2026 16:46
stevencartavia
approved these changes
Oct 6, 2026
mablr
approved these changes
Oct 6, 2026
Member
|
finally ! |
mablr
enabled auto-merge (squash)
October 6, 2026 16:51
DaniPopes
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aws-kms feature pinned
timeto exactly 0.3.47 because aws-smithy-types 1.5.0 did not compile with time 0.3.48. The resolved aws-smithy-types 1.6.1 compiles with time 0.3.55 on Rust 1.98, so the pin is stale. It also blocks any workspace that depends on foundry-wallets together with a crate that needs time 0.3.51 or newer, which is the case for the reth node crates through vergen in the upcoming reth-anvil work in foundry-rs/foundry.