Make the repository lint-clean - #68
Merged
Merged
Conversation
vigneshwerv
force-pushed
the
claude/lint-clean
branch
from
August 10, 2026 19:14
4fcacd5 to
15eab26
Compare
vigneshwerv
force-pushed
the
claude/experimental-opt-in
branch
from
August 10, 2026 21:18
838dece to
8e20986
Compare
vigneshwerv
force-pushed
the
claude/lint-clean
branch
from
August 10, 2026 21:18
15eab26 to
1232a9e
Compare
vigneshwerv
force-pushed
the
claude/experimental-opt-in
branch
from
August 10, 2026 21:23
8e20986 to
be3cf9f
Compare
vigneshwerv
force-pushed
the
claude/lint-clean
branch
from
August 10, 2026 21:23
1232a9e to
2c07567
Compare
vigneshwerv
force-pushed
the
claude/experimental-opt-in
branch
from
August 10, 2026 21:39
be3cf9f to
ba67611
Compare
vigneshwerv
force-pushed
the
claude/lint-clean
branch
from
August 10, 2026 21:39
2c07567 to
d12fd6a
Compare
vigneshwerv
approved these changes
Aug 10, 2026
vigneshwerv
force-pushed
the
claude/experimental-opt-in
branch
from
August 10, 2026 22:25
ba67611 to
fbc0cb6
Compare
vigneshwerv
force-pushed
the
claude/lint-clean
branch
from
August 10, 2026 22:25
d12fd6a to
820cf4c
Compare
vigneshwerv
force-pushed
the
claude/experimental-opt-in
branch
from
August 10, 2026 22:38
fbc0cb6 to
47b0ec2
Compare
`rake lint` reported eighteen offences, none of them in CI and none of them test failures -- but the task exists now, so leaving it red is a trap for whoever wires it up. Twenty-five were autocorrected, almost all argument alignment and parallel assignment in the pre-existing OAuth conformance tests. Two needed a decision: `create_token` was over both AbcSize and MethodLength. Building the request moves to `token_request`, which is a thing worth naming on its own -- it is where RFC 6749's client_credentials grant and Basic auth actually happen, and the four spec tests around it pass unchanged. `Metrics/AbcSize` is now excluded for `test/**/*`. An assertion-heavy test scores high on ABC by counting assertions, which is not a signal worth acting on; the same reasoning already excludes `Metrics/CyclomaticComplexity` there. At the top of the stack rather than amended into the branches that own these files: the offences span `lib/fragment_client.rb`, `.rubocop.yml` and `test/unit_test.rb`, which three different PRs touch, and threading a style pass through all of them risks conflicts for no gain when RuboCop is not gated.
vigneshwerv
force-pushed
the
claude/lint-clean
branch
from
August 10, 2026 23:18
820cf4c to
1275f7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #67. Style only; no behaviour changes, and no test outcomes change.
To be clear about what was and was not broken: all 94 tests pass, on Ruby 3.2.8, 3.3.8 and 3.4.3. CI gates
rake test, the schema freshness check, the GraphQL name grep,srb tcand the snapshot check — RuboCop is not among them, so nothing here was blocking a merge. But #56 added arake linttask, and leaving it reporting eighteen offences is a trap for whoever wires it into CI.What changed
Twenty-five offences autocorrected, almost all argument alignment and parallel assignment in the pre-existing OAuth conformance tests.
Two needed a decision:
create_tokenwas over bothAbcSizeandMethodLength. Building the request moves out totoken_request, which is worth naming on its own — it is where RFC 6749'sclient_credentialsgrant and Basic auth actually happen. The four spec tests around it pass unchanged, which is the check that matters for a method this sensitive.Metrics/AbcSizeis now excluded fortest/**/*. An assertion-heavy test scores high on ABC by counting assertions; that is not a signal worth acting on. The same reasoning already excludesMetrics/CyclomaticComplexitythere.Why at the top of the stack
The offences span
lib/fragment_client.rb,.rubocop.ymlandtest/unit_test.rb, which three different PRs touch. Threading a style pass down through all of them risks conflicts for no gain while RuboCop is ungated. The consequence is that intermediate branches stay lint-dirty and only the final state is clean — worth knowing if you merge partially.Verified
rubocop: 29 files, no offences.rake test: 94 runs, 0 failures.srb tc: clean. Live suite: 4 runs, 0 failures, no leftover ledgers.🤖 Generated with Claude Code