Ensure the end marker never leaks#207
Open
jupenur wants to merge 2 commits into
Open
Conversation
Member
Author
|
Rebased and force-pushed to get a clean diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #206. I was not able to reproduce the leak I saw in #206 and so did not find the root cause. However, this PR fixes another marker-related bug, where, if the browser canceled a script request before receiving headers (for example due to navigating away from the page that issued it), the end marker would not be produced, and WEBCAT would compute the hash for the hooks instead of the empty content. The same fix also guards against the end marker leaking: if the end marker is not seen when expected, the stream filter writes an empty body. That should fully mitigate the security impact of #206.
As for tests,
test_webcatnow fails without retries if a marker is ever seen in the text content.This also fixes #208, another case related to canceled requests: when partial response content has already been received, and the request is canceled, the response is now ignored.