This repository was archived by the owner on Feb 4, 2020. It is now read-only.
Calls to non-existing includes should force a cache miss to display compiler error#200
Closed
hubx wants to merge 2 commits intofrerich:masterfrom
Closed
Calls to non-existing includes should force a cache miss to display compiler error#200hubx wants to merge 2 commits intofrerich:masterfrom
hubx wants to merge 2 commits intofrerich:masterfrom
Conversation
Contributor
|
See also #179 The problem is: a missing include does mean that it is a miss. It can also be a header change and the include might be obsolete. |
added 2 commits
August 11, 2016 15:04
If clcache is called with a non existing include, force a cache miss, to see the compiler error
Contributor
|
Could you please check, if #179 does the job? I think I fixed it there. |
Contributor
Author
|
@webmaster128 Technically #179 sounds much more profound what I did here. I saw that you are still committing to that PR just now. Ready to test it when you are. :) |
Contributor
I am happy with the current state in terms of correctness, thus I pinged you here. Please ignore the coverage fails in #179. Those happen because integrationtests are not counted properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment clcache will fail when parsing a non-existing header to generate
includesContentHashforManifestRepository.getIncludesContentHashForFiles(listOfIncludes)with a non-existing include inlistOfincludesThe proposed is not a elegant solution. I don't see a clever way to raise a ForceCacheMissException which could be handled. Please feel free adapt as you wish.