fix(network): preserve cached data on transient network errors - #336
Open
tkhorik wants to merge 1 commit into
Open
fix(network): preserve cached data on transient network errors#336tkhorik wants to merge 1 commit into
tkhorik wants to merge 1 commit into
Conversation
queryFn resolved a Result instead of rejecting, so React Query treated network failures as successful fetches — no retries, and cached data got overwritten with the error. This caused the "Network Error" screen on every app resume from background. - unwrap() throws on a failed Result instead of returning it as data - queries only show the error screen when there's no cached data yet - retry only on transient network errors, not 401/status - add axios timeout so hung requests fail fast enough to retry Fixes friendly-social#263
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
queryFn resolved a Result instead of rejecting, so React Query treated network failures as successful fetches — no retries, and cached data got overwritten with the error. This caused the "Network Error" screen on every app resume from background.
Fixes #263