Revert Hydrogen route from main (merged prematurely via #23) - #26
Merged
Conversation
The Shopify Hydrogen install route and its changeset landed on main by accident: PR #23 (telemetry) was branched off the unmerged hydrogen-wrapper-prompt branch and squash-merged, carrying the Hydrogen work in with it. That work belongs to PR #22, which had not been reviewed/merged on its own. This restores templates/install-prompt.md to its pre-Hydrogen state (ea59c33) and removes .changeset/hydrogen-wrapper-prompt.md, so the Hydrogen feature can go back through PR #22 properly. No other files touched — the telemetry changes from #23 stay in place. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Shopify Hydrogen install route landed on
mainby accident. PR #23 (default-on telemetry) was branched off the unmergedhydrogen-wrapper-promptbranch instead ofmain, then squash-merged — so the Hydrogen commits and their changeset rode in under the telemetry PR title (e65b4c6). That work belongs to PR #22, which was never reviewed/merged on its own, and it also pulled the Hydrogen entry into the pending Version Packages PR (#25).What this does
Backs the Hydrogen work out of
mainso it can go through PR #22 properly:templates/install-prompt.mdto its pre-Hydrogen state (ea59c33) — removes the@subtextdev/hydrogenpre-check reference, the@shopify/hydrogenframework-detection line, and the full "Shopify Hydrogen" framework-patterns block..changeset/hydrogen-wrapper-prompt.md.Nothing else is touched — the telemetry changes from #23 stay in place, and README (which Hydrogen never modified) is untouched.
Verification
templates/install-prompt.mdis byte-identical toea59c33(empty diff) and contains 0hydrogenreferences.mainafter this merges istelemetry-default-on.md, so the Version Packages PR will drop the Hydrogen entry.Follow-up
PR #22 stays open and can be merged normally when the Hydrogen route is ready for review.
🤖 Generated with Claude Code
Note
Low Risk
Documentation and changeset-only revert with no runtime or auth impact; telemetry and other main-line changes are untouched.
Overview
Removes the Shopify Hydrogen install path from the Subtext wizard install prompt on
main, restoring the template to its pre-Hydrogen behavior.templates/install-prompt.mdno longer treats@subtextdev/hydrogenas an “already installed” signal, drops@shopify/hydrogenas a first-priority framework detector, and deletes the full Shopify Hydrogen framework-patterns block (wrapper package, CSP, analytics, identity, cart linkage). Generic flows (Next.js, Remix, Vite, etc.) are unchanged.The pending changeset
.changeset/hydrogen-wrapper-prompt.mdis removed so Version Packages no longer picks up a Hydrogen release note from this accidental merge.Reviewed by Cursor Bugbot for commit 30aa10d. Bugbot is set up for automated code reviews on this repo. Configure here.