Modernize codebase with ES2022 features, fix code style issues, and add vnStat 2.x compatibility

.github/workflows/node.js.yml

@@ -28,17 +28,26 @@ jobs:
         node-version: ${{ fromJson(needs.lts_versions.outputs.matrix) }}
     steps:
       - uses: actions/checkout@v6
+
+      - run: "sudo apt-get update && sudo apt-get install -y vnstat"
+
       - name: Test on Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v6
         with:
           node-version: ${{ matrix.node-version }}
+
       - run: npm install
+        env:
+          NODE_APP_BIN: ${{ secrets.NODE_APP_BIN }}
+
       - run: npm test
         env:
-          NODE_APP_IFACE: ${{ NODE_APP_IFACE }}
+          NODE_APP_BIN: './testing/mock-vnstat'
+          NODE_APP_IFACE: ${{ secrets.NODE_APP_IFACE }}
           DOTEST_NOCOV: ${{ secrets.DOTEST_NOCOV }}
           DOTEST_MINCOV: ${{ secrets.DOTEST_MINCOV }}
           DOTEST_COVFUNCTIONS: 100
+
       - name: Coveralls Parallel
         uses: coverallsapp/github-action@master
         if: always()

README.md

@@ -14,27 +14,27 @@ Example
 -------
 
 ```js
-var vnstat = require ('vnstat-dumpdb') ();
+const vnstat = require( 'vnstat-dumpdb' )();
 
 // Get traffic per day
-vnstat.getStats ('eth0', function (err, data) {
-  if (err) {
-    console.log (err);
+vnstat.getStats( 'eth0', ( err, data ) => {
+  if ( err ) {
+    console.log( err );
     return;
   }
 
-  console.log (data.traffic.days);
-});
+  console.log( data.traffic.days );
+} );
 
 // Read config setting
-vnstat.getConfig (function (err, config) {
-  if (err) {
-    console.log (err);
+vnstat.getConfig( ( err, config ) => {
+  if ( err ) {
+    console.log( err );
     return;
   }
 
-  console.log ('Interfaces updating every ' + config.UpdateInterval + ' minutes');
-});
+  console.log( `Interfaces updating every ${config.UpdateInterval} minutes` );
+} );
 ```
 
 
@@ -66,15 +66,15 @@ Each method below takes a callback _function_ which gets two arguments:
 * `data` - Result `object` or not set when error
 
 ```js
-function myCallback (err, data) {
-  if (err) {
-    console.log (err);
-    console.log (err.stack);
+const myCallback = ( err, data ) => {
+  if ( err ) {
+    console.log( err );
+    console.log( err.stack );
     return;
   }
 
-  console.log (data);
-}
+  console.log( data );
+};
 ```
 
 
@@ -93,13 +93,13 @@ getStats ( [iface], callback )
 
 Get statistics for one, multiple or all interfaces.
 
-* One: `vnstat.getStats ('eth0', callback)`
-* All: `vnstat.getStats (false, callback)`
+* One: `vnstat.getStats( 'eth0', callback )`
+* All: `vnstat.getStats( false, callback )`
 
 
 ```js
 // Get traffic for interface en1
-vnstat.getStats ('en1', console.log);
+vnstat.getStats( 'en1', console.log );
 
 // Output
 { id: 'en1',
@@ -157,14 +157,14 @@ getConfig ( callback )
 Get vnStat configuration.
 
 ```js
-vnstat.getConfig (function (err, config) {
-  if (err) {
-    console.log (err);
+vnstat.getConfig( ( err, config ) => {
+  if ( err ) {
+    console.log( err );
     return;
   }
 
-  console.log ('Interfaces updating every ' + config.UpdateInterval + ' seconds');
-});
+  console.log( `Interfaces updating every ${config.UpdateInterval} seconds` );
+} );
 ```
 
 

TESTING.md

@@ -14,30 +14,30 @@ The dummy database includes:
 
 ```js
 // Set environment variable before running tests
-NODE_APP_BIN=./fixtures/mock-vnstat npm test
+NODE_APP_BIN=./testing/mock-vnstat npm test
 
 // Or use it directly in your code
-var vnstat = require('vnstat-dumpdb')({
-  bin: './fixtures/mock-vnstat'
-});
+const vnstat = require( 'vnstat-dumpdb' )( {
+  bin: './testing/mock-vnstat',
+} );
 
-vnstat.getStats('eth0', function(err, data) {
+vnstat.getStats( 'eth0', ( err, data ) => {
   // Test with dummy data
-  console.log(data);
-});
+  console.log( data );
+} );
 ```
 
 **Managing the dummy database:**
 
 ```bash
 # Display information about the dummy database
-node generate-dummy-db.js info
+node testing/validate-dummy-db.js info
 
 # Validate the dummy data format
-node generate-dummy-db.js validate
+node testing/validate-dummy-db.js validate
 
 # Run the example
-cd fixtures && node example.js
+cd testing && node example.js
 ```
 
-For detailed information about the dummy database and testing, see [fixtures/README.md](fixtures/README.md).
+For detailed information about the dummy database and testing, see [testing/README.md](testing/README.md).

eslint.config.js

@@ -103,7 +103,7 @@ module.exports = [
       'no-sequences': 'error',
       'no-shadow': 'error',
       'no-shadow-restricted-names': 'error',
-      'func-call-spacing': 'error',
+      'func-call-spacing': ['error', 'never'],
       'no-sparse-arrays': 'warn',
       'no-sync': 'warn',
       'no-ternary': 'off',
@@ -118,6 +118,15 @@ module.exports = [
       'no-unreachable': 'error',
       'no-unused-vars': 'warn',
       'no-use-before-define': 'error',
+      'no-var': 'error',
+      'prefer-const': 'error',
+      'prefer-arrow-callback': 'error',
+      'arrow-body-style': ['error', 'as-needed'],
+      'object-shorthand': ['error', 'always'],
+      'prefer-destructuring': ['error', {
+        array: false,
+        object: true,
+      }],
       'no-useless-concat': 'error',
       'no-warning-comments': 'warn',
       'no-with': 'error',
@@ -129,6 +138,7 @@ module.exports = [
       'operator-assignment': ['error', 'always'],
       'operator-linebreak': ['error', 'before'],
       'padded-blocks': 'off',
+      'prefer-template': 'error',
       'quote-props': ['error', 'consistent'],
       'quotes': ['error', 'single', 'avoid-escape'],
       'radix': 'error',