fix: registry commands respect AWS_CONFIG_FILE#927
Open
yuriipolishchuk wants to merge 2 commits intofwdcloudsec:mainfrom
Open
fix: registry commands respect AWS_CONFIG_FILE#927yuriipolishchuk wants to merge 2 commits intofwdcloudsec:mainfrom
yuriipolishchuk wants to merge 2 commits intofwdcloudsec:mainfrom
Conversation
granted registry add/sync/remove/setup ignored the AWS_CONFIG_FILE environment variable and always wrote to ~/.aws/config. The assume command was fixed for this in fwdcloudsec#229, but registry commands were missed. This change reuses cfaws.GetAWSConfigPath() which already handles AWS_CONFIG_FILE correctly, consistent with AWS CLI behavior: https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html
meyerjrr
requested changes
Mar 21, 2026
Collaborator
meyerjrr
left a comment
meyerjrr
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Just have one minor nitpick
|
|
||
| configPath := filepath.Join(h, ".aws", "config") | ||
| return configPath, nil | ||
| return cfaws.GetAWSConfigPath(), nil |
Collaborator
There was a problem hiding this comment.
Instead of returning cfaws.GetAWSConfigPath() here can we update the uses of getDefaultAWSConfigLocation in the registry to instead just call cfaws.GetAWSConfigPath() for consistency across the codebase?
Author
…test Drop the getDefaultAWSConfigLocation wrapper and call cfaws.GetAWSConfigPath directly to match how assume / sso / credentials already resolve the AWS config path (per review on fwdcloudsec#927). Also sandbox HOME and tighten the path assertion in TestLoadAWSConfigFile_DefaultPath so it neither touches the user's real ~/.aws/ nor passes for unrelated paths like ".aws/config-backup".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #926
Registry commands (
add,sync,remove,setup) ignoredAWS_CONFIG_FILEand always used~/.aws/config. This was fixed forassumein #229 but missed for registry.The fix reuses
cfaws.GetAWSConfigPath()— the same function already used byassume,granted sso, andgranted credentialsto resolve the config path.Added tests for both custom and default paths.