tests: a missing input skips loudly instead of failing into a baseline (Refs #2161) - #2739
Merged
Conversation
…e (Refs #2161) `specs/scratch/` is gitignored -- 578 MB of generated benchmark drafts, re-derivable from the 343 committed `scripts/gen_w<NNN>.py` generators. So in a fresh clone this whole target panicked on `read_dir`, and the failure was then recorded in the CI baseline as "known failing": 358 tests, 15% of the suite, disabled by a .gitignore line and made invisible by a ledger. A missing INPUT is not a failing test. It is also not a passing one, which is why the guard PRINTS rather than returning quietly -- a silent skip is how the count reached 358 in the first place. Each skip names the test, the directory, and how to restore it. before 358 failing, all of them for the same absent directory after 357 skipping loudly, 1 failing That one is the point. `corpus_classifier_matches_lean_completeness` fails on a real disagreement -- specs/api/tri_net_api.t27, Rust says not lowerable and the Lean theorem says lowerable -- and it fails identically before and after this change, checked. It was the only true failure in the target and it sat among 357 false ones, in a baseline that recorded all 358 as the same thing. Nothing here regenerates the witnesses: 578 MB does not belong in a test run. When they are present the 357 run as before.
Contributor
PR DashboardGenerated at: 2026-08-27 20:21:28 UTC
Summary
Seal Status
|
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
PR DashboardGenerated at: 2026-08-27 20:48:50 UTC
Summary
Seal Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
specs/scratch/is gitignored — 578 MB of generated benchmark drafts, re-derivable from the 343 committedscripts/gen_w<NNN>.pygenerators. So in a fresh clone this whole target panicked onread_dir, and the failure was then recorded in the CI baseline as known failing: 358 tests, 15% of the suite, disabled by a .gitignore line and made invisible by a ledger.A missing input is not a failing test. It is also not a passing one — which is why the guard prints rather than returning quietly. A silent skip is how the count reached 358 in the first place. Each skip names the test, the directory, and how to restore it.
That one is the point.
corpus_classifier_matches_lean_completenessfails on a real disagreement —specs/api/tri_net_api.t27, where the Rust classifier says not-lowerable and the Lean theorem says lowerable — and it fails identically before and after this change, checked by stashing.It was the only true failure in the target, and it sat among 357 false ones. The baseline recorded all 358 as the same thing, which is what a ledger does to a population it cannot distinguish: it makes the one that matters cost exactly as much attention as the 357 that do not.
Nothing here regenerates the witnesses — 578 MB does not belong in a test run. When they are present the 357 run as before.
Refs #2161