A moved arm left its guard behind - #2790
Merged
Merged
Conversation
`parse-complete --show <spec>` is documented to print the tokens top-level drop-recovery discarded, grouped by line. Since #2781 it printed the FALLBACK view instead, and the token view was unreachable. The `--fallbacks --show` arm was moved above the `--show` handler so it could win when both flags are given, and its `if fallbacks` guard was left at the old site. Nothing failed: both outputs are plausible, both name the file, both print line numbers. The flag that selects between them was simply no longer read. Found by using `--show` for something else and getting the wrong picture. There is no test in this CLI that a flag still selects what it names -- which is how a guard can be dropped in a refactor and nothing notices. parse-complete --show <spec> -> 159 token(s) DISCARDED parse-complete --fallbacks --show <spec> -> 11 whole-block fallback(s) Refs #2754 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
PR DashboardGenerated at: 2026-08-29 07:46:58 UTC
Summary
Seal Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2754
parse-complete --show <spec>is documented to print the tokens top-level drop-recovery discarded, grouped by line. Since #2781 it printed the fallback view instead, and the token view was unreachable.The
--fallbacks --showarm was moved above the--showhandler so it could win when both flags are given, and itsif fallbacksguard was left at the old site.Nothing failed. Both outputs are plausible, both name the file, both print line numbers. The flag that selects between them was simply no longer read.
Found by using
--showfor something else and getting the wrong picture. There is no test in this CLI that a flag still selects what it names — which is how a guard gets dropped in a refactor and nothing notices.🤖 Generated with Claude Code