A pub field is a field - #2802
Merged
Merged
Conversation
pub struct HealthStatus {
pub is_healthy: bool,
pub status_code: u16,
...
}
parsed as a struct with NO fields. The field reader splits on `:` and then
rejects any name containing a space, so `pub is_healthy` was thrown away -- and
all five with it.
The consequence is worse than the omission. An empty field list compares equal to
any other empty field list, so this five-field type and an unrelated
`pub const HealthStatus = struct { variants : , }` placeholder in a different
subsystem were reported as DUPLICATED -- "the same fields written twice" -- when
they share nothing.
conflicted names 79 -> 80
definitions with unreadable fields 9 -> 6
FOUND BY AN AGENT ASKED TO CHECK COVERAGE, not by me. It compared the classified
list against the detector's own output in both directions, found them equal, and
then went further and hand-verified nine of the conflicts -- choosing the riskiest
rather than the easiest -- which is where `HealthStatus` surfaced as a name the
detector had put in the wrong bucket entirely.
AND THE RATCHET EARNED ITS KEEP THE DAY AFTER IT WAS WRITTEN. On a real change,
with no planting:
ledger 79 name(s), observed 80
+ HealthStatus NEW conflict
exit 1
Re-blessed to 80. Thirteen tests; the two new ones cover a `pub` field being read
and the conflict that follows from reading it.
Refs #2774
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
PR DashboardGenerated at: 2026-08-29 11:18:04 UTC
Summary
Seal Status
|
…et one day old (197-199) A type is declared three ways and a field is written two; the scanner learned the first lesson and had to learn it again one level down. A verifier whose set comparison came back exact went on to hand-check the nine riskiest conflicts anyway, and that is where the misfiled name was. And the ratchet written last iteration fired on a real change in this one. Refs #2774 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
PR DashboardGenerated at: 2026-08-29 11:19:22 UTC
Summary
Seal Status
|
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
PR DashboardGenerated at: 2026-08-29 11:30:27 UTC
Summary
Seal Status
|
# Conflicts: # .claude/skills/ci-gates/SKILL.md
Contributor
PR DashboardGenerated at: 2026-08-29 11:34:00 UTC
Summary
Seal Status
|
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
gHashTag
added a commit
that referenced
this pull request
Aug 29, 2026
…2806) Refs #2774 `tri types dup` reports which names have more than one definition and `tri types ratchet` holds that set. Neither can say what KIND of conflict a name is, and the two kinds want opposite repairs: DRIFT one concept that grew a second definition -- converge them DISTINCT two concepts that collided on a name -- rename, or judge and accept All 80 were opened and decided with the reading written down: 46 DRIFT, 34 DISTINCT. docs/TYPE_CONFLICTS.md is the summary, docs/reports/type_conflicts_classified.json is the record. A written reading of a tree stops being true without anything failing, so `tri types classified` re-takes it and fails in both directions -- UNJUDGED for a conflict nobody has read, STALE for a row about a name that is no longer conflicting. Passing over STALE is how a document becomes decoration. Wired into corpus-ratchet.yml; proven red both ways before landing. It earned itself on the first run: HealthStatus, the eightieth name, appeared when #2802 taught the field reader that `pub name: T` is a field. Recorded rather than hidden: four verdicts are reported CONFLICTED by the tool only because it cannot parse `variants : ,` on one side. Those verdicts came from reading the source; the tool agreeing is a coincidence. ci-gates 205-207.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(tri): a pub field is a field
parsed as a struct with NO fields. The field reader splits on
:and thenrejects any name containing a space, so
pub is_healthywas thrown away -- andall five with it.
The consequence is worse than the omission. An empty field list compares equal to
any other empty field list, so this five-field type and an unrelated
pub const HealthStatus = struct { variants : , }placeholder in a differentsubsystem were reported as DUPLICATED -- "the same fields written twice" -- when
they share nothing.
FOUND BY AN AGENT ASKED TO CHECK COVERAGE, not by me. It compared the classified
list against the detector's own output in both directions, found them equal, and
then went further and hand-verified nine of the conflicts -- choosing the riskiest
rather than the easiest -- which is where
HealthStatussurfaced as a name thedetector had put in the wrong bucket entirely.
AND THE RATCHET EARNED ITS KEEP THE DAY AFTER IT WAS WRITTEN. On a real change,
with no planting:
Re-blessed to 80. Thirteen tests; the two new ones cover a
pubfield being readand the conflict that follows from reading it.
Refs #2774
Co-Authored-By: Claude Opus 5 noreply@anthropic.com