Conversation
312: a match arm covers `StmtForRange | StmtWhile | StmtFor` and the comment directly under it says "a `for`/`while`/`if` was dropped". `if` is in the sentence and not in the pattern. A top-level `if` in a test block therefore became `// (stmt: StmtIf)`, the flag was set true and never false, and the test reported PASSED. When a comment enumerates cases, the list is checkable against the arm in one glance. 313: my first probe of that finding read the wrong spec -- `lucas_accumulator.t27` nests its `if` inside a `while`, which routes through a path that handles it -- and I nearly recorded a true report as not reproducing. The claim said TOP-LEVEL `if`; I tested an `if`. When a report names a position, the position is part of the claim, and ignoring it produces a confident refutation rather than a missed defect. Refs #2871
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
gHashTag
enabled auto-merge (squash)
August 29, 2026 19:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two sections from #2871.
312 — the match arm's own comment named the case it was missing.
ifis named in the sentence and is not in the arm. The cost: a top-levelifin a test block became// (stmt: StmtIf), so the accumulator flag was set true and never set false — the test could not fail and reported PASSED. When a comment enumerates cases, that list is checkable against the pattern above it in one glance.313 — two probes disagreed and the first one was mine. My first check of that finding read
lucas_accumulator.t27, found theiffully emitted, and I nearly recorded the report as not reproducing. It was reproducing — inposit_ladder_control.t27, where theifsits at the top level of the test body; inlucas_accumulatorit is nested inside awhile, which routes through a path that handles it.The claim said top-level
if. I tested anif. When a report names a position, the position is part of the claim — and getting it wrong costs more than a missed defect: it produces a confident refutation of a true finding.Refs #2871