Conversation
A parser audit found `pub` on a struct field (41 sites) and the `!` error-union marker (4) both consumed and recorded nowhere -- the shape of #2867, where the lexer dropped a width suffix and the Zig shift path then re-invented it and a function panicked. These two are not defects today, and the difference is one question: does anything downstream read it? The Rust backend emits `pub` on every field regardless, Zig and C have no field visibility, and three of the four `!` sites are bodiless declarations no backend emits while the fourth is noreturn. Grep count 45, live consequence 0. The count is not the finding. For a lost piece of information the finding is the consumer, and looking for one costs two commands: generate the output both ways and diff it. Without that a report reads "45 sites" and sounds like the CORDIC shift, which was 376 sites and a wrong gate on silicon. Refs #2880
gHashTag
enabled auto-merge (squash)
August 29, 2026 20:17
Contributor
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A parser audit found two modifiers consumed and recorded nowhere:
pubon a struct field (41 sites) and the!error-union marker on a return type (4). Both are the shape of #2867 — where the lexer advanced pastu64and stored nothing — and that one was a defect, because the Zig shift path then re-invented the width and a function panicked at run time.These two are not, and the difference is one question: does anything downstream read it?
pubon every struct field regardless of the spec; Zig has no field visibility; C has none. Three of three produce identical output either way.!sites, three are bodiless declarations ending in;that no backend emits, and the fourth is Zig's noreturn!— a different construct sharing a token.Grep count 45. Live consequence 0.
The count is not the finding. For a lost piece of information the finding is the consumer, and looking for one costs two commands: generate the output both ways and diff. Without that, a report reads "45 sites" and sounds like the CORDIC shift — which was 376 sites and a wrong gate on silicon.
What to do with a latent one: record it, say plainly that nothing reads it today, and say where to look on the day something does. Filed as #2880. Fixing it means adding a field nothing consumes — a change with no measurement that could show it worked.
Refs #2880