Conversation
… improvements 335: an audit ruled out the braceless `else` with "the corpus has 0 such sites -- all 37 `} else <non-brace>` hits are paren-less `else if`". There are four. They do not match that pattern because the `if` has no braces either: `if (a >= b) return a else return b;` is one line, so there is no `}` before the `else` to anchor on. A zero from a pattern that cannot match the real spelling CLOSES the question, which makes the defect harder to find again than if it had never been reported. Before believing a zero, feed the pattern a case you know exists. 336: two ratchets went red in one hour and neither on a regression. The Lean/Rust classifier reported four new disagreements because four specs that could not be PARSED became parseable, so the classifier could finally disagree with a theorem that had always been wrong. The corpus ratchet reported 19 unexpected passes and 1 unexpected failure -- the nineteen are that same unblocking, and the one failure is one of the nineteen, now parsing and therefore now measurable for discard. A down-only ratchet fails on an improvement exactly as on a regression, and that is the design. The work is the same work, and the failure mode is doing it without writing the reason down. Refs #2883, #2887
gHashTag
enabled auto-merge (squash)
August 29, 2026 21:25
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
PR DashboardGenerated at: 2026-08-29 21:26:00 UTC
Summary
Seal Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two sections from #2883 and #2887.
335 — a count of zero from a pattern that cannot match. An audit ruled out the braceless
elsewith "the corpus has 0 such sites — all 37} else <non-brace>hits are paren-lesselse if". There are four:They do not match
} else <non-brace>because theifhas no braces either — the whole statement is one line, so there is no}before theelsefor the pattern to anchor on. The search was written for the shape the searcher was imagining.A zero from a pattern that cannot match the real spelling is the expensive kind, because it closes the question: the next reader sees it was already checked. Before believing a zero, feed the pattern a case you know exists.
336 — both ratchets fired on improvements, and both were right. Two went red in one hour, neither on a regression:
A down-only ratchet fails on an improvement exactly as it fails on a regression, and that is the design. The work is the same work: read what moved, decide which side is stale, re-bless with the reason written down. The failure mode is doing it without the reason — a ledger full of
unclassifiedentries is one nobody can argue with later.And one thing to check every time, because the tooling does not:
--bless-expectationsdoes not raise or lowermax_entries, so a freshly blessed ledger can still fail on its cap.Refs #2883, #2887