Conversation
uint64_t set(*Bitmap bitmap);
error: type specifier missing, defaults to 'int'
error: expected ')'
`param_type_to_c` has arms for `?T`, `[]T`, `[]const T`, `[T; N]` and `[N]T`,
and had none for the prefix star, so the t27 text passed through verbatim. In C
the star belongs to the declarator: written first, `Bitmap` parses as the
declared NAME carrying an implicit-int type, and the second identifier is then
unexpected. 52 of 578 generated headers carried it.
files with `(*Type name` 52 -> 0
cc accepts 174 -> 174
The headline does not move, and that is the measurement rather than a
disappointment: of 404 rejected files only 20 are blocked by a single error
family and the median carries four or five, so no one family is a lever here.
What it moves is what comes next. With pointers typed correctly,
error: member reference type 'Bitmap *' is a pointer; did you mean to use '->'?
becomes its own single-family file -- invisible while the parameter never parsed.
The arm recurses rather than prepending to raw text: `*[]u8` is `uint8_t**`,
and the mutation that skips the recursion emits `[]u8*`.
Closes #2929
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
gHashTag
enabled auto-merge (squash)
August 30, 2026 00:24
Contributor
Contributor
PR DashboardGenerated at: 2026-08-30 00:26:23 UTC
Summary
Seal Status
|
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
PR DashboardGenerated at: 2026-08-30 00:28:10 UTC
Summary
Seal Status
|
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
param_type_to_chas arms for?T,[]T,[]const T,[T; N]and[N]T—and had none for the prefix star. In C the
*belongs to the declarator; writtenfirst,
Bitmapparses as the declared name with an implicit-int type.52 of 578 generated headers carried it.
What it does and does not move
(*Type nameccacceptsZero on the headline, and that is the measurement rather than a disappointment:
of 404 rejected files only 20 are blocked by a single error family, and the
median carries four or five. No one family is a lever in this backlog (#2925).
What it moves is what comes next:
now its own single-family file — invisible while the parameter never parsed.
Mutation-checked
the_star_arm_recurses_rather_than_prepending_to_raw_text(*[]u8gave[]u8*, notuint8_t**)Closes #2929