Conversation
`Harness scratch directories` failed on master at corpus_zig_bodies.rs: three #[test] functions, a scratch directory keyed by process::id() alone, and a remove_dir_all of it. That is the shape #2954 closed across five files, reintroduced by #2966 -- the same pass that wired the gate. The race cannot fire today: only one of the three tests touches the directory. The gate refuses the SHAPE rather than the outcome, and that is the right call -- a second test using the same helper is one edit away, and that edit would not look like the change that broke anything. Keyed by an AtomicUsize counter now, like every other scratch helper in the tree. --gate exits 0, the five-leg control passes, the three tests still pass. The gate went red within a day of being wired, on a file written by the person who wired it, and it was the only thing that noticed. Closes #2972 Refs #2954 Refs #2966 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
gHashTag
enabled auto-merge (squash)
August 30, 2026 18:20
Contributor
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harness scratch directoriesfailed on master atcorpus_zig_bodies.rs— three#[test]functions, a scratch directory keyed byprocess::id()alone, and aremove_dir_allof it. The shape #2954 closed across five files, reintroduced by #2966, the same pass that wired the gate.The race cannot fire today: only one of the three tests touches the directory. The gate refuses the shape rather than the outcome, which is why it fired on the commit that introduced the defect instead of on a later, innocent one.
Keyed by an
AtomicUsizecounter now, like every other scratch helper in the tree.--gateexits 0, the five-leg control passes, the three tests still pass.Closes #2972 · Refs #2954 · Refs #2966
🤖 Generated with Claude Code