fix(tri): an unplaceable failure is not a generation refusal - #2996
Merged
Conversation
`tri vsim funnel` shipped in #2993 with two arms returning `Stage::Gen` for states nobody had measured: a process that could not be spawned, and a failure whose message matched none of the four patterns. Both file a hole in this reader as a verdict about the spec -- the shape ci-gates 428 names, written in the same session and then present in my own code. * new `Unattributed` stage, with its own printed row * attribution extracted into `attribute_failure(&log)`, so the decision can be tested without spawning anything * two tests: a message matching no arm is Unattributed and NOT Gen; and each of the four arms is reachable by the compiler's own words Measured over 650 specs at d7f20a5: the new row reads 0 and every other row is identical (69 / 410 / 0 / 9 / 107 / 55 / 0). Nothing was being misfiled today -- the change is preventive, and the zero is printed beside the hits because a reader cannot otherwise tell "none" from "not looked for". Refs #2987
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
PR DashboardGenerated at: 2026-08-30 22:18:08 UTC
Summary
Seal Status
|
Contributor
PR DashboardGenerated at: 2026-08-30 22:28:42 UTC
Summary
Seal Status
|
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-audit of #2993 against the section that merged beside it.
tri vsim funnelhad two arms returningStage::Genfor states nobodymeasured:
Both file a hole in the reader as a verdict about the spec. That is exactly the
shape of ci-gates 428, which merged an hour earlier in #2995 — written after
three status readers of mine were wrong in one session, and then sitting in my
own code.
The change
Unattributedstage with its own printed row,failed, and nothing said whereattribute_failure(&log), so the decision can betested without spawning a process
Unattributedand notGen(
""too), and each of the four arms is reachable by the compiler's own wordsMeasured, 650 specs, at
d7f20a559Nothing was being misfiled today. The change is preventive, and the row
prints its zero rather than being omitted, because a reader cannot otherwise
tell none from not looked for — the same reason the vacuity census on this
page prints its zeros beside its hits.
Refs #2987
🤖 Generated with Claude Code