docs(compiler): the referee test's comment named a population that never shipped - #3017
Merged
Conversation
…ver shipped `a_loop_without_a_jump_is_unchanged` is the test that DEFINES the set a guard-flag change must leave byte-identical, and its comment read "the corpus delta is 37 of 581 generated .v files". 37 is patch C's figure -- for a change that guarded `return` as well, the half deliberately cut before landing. What shipped moves 7, re-measured by two independent readers, and this branch's own `5063edb19` re-sealed 19 seals over exactly those 7 specs. The same sentence also listed `return` among the statements the fixture avoids. The shipped guard does not know about `return` at all; that is #2989 and it is not landed. Corrected in place with the reason, not left standing beside a newer number. Comment only -- no emitted byte moves, so no seal drifts; the `FROZEN_HASH` reseal is the M5 freeze and nothing else. Refs #2988 Refs #2989 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
gHashTag
added a commit
that referenced
this pull request
Sep 3, 2026
The StmtBreak comment carried two numbers, both scoped to a reading this fix superseded. The population is 643 generated .v files, not the 581 under specs/. And the sites are 17 in 8 files, not fourteen. The second is the one worth having. `tri jumps census` on master reads 17 sites sharing 14 guard FLAGS, and fourteen was also the count of `disable fork;` lines before the fix. So a reader checking 14 against the census finds 14 and concludes the comment is right: a wrong number of one quantity that equals a right number of another, and therefore self-confirming. Second occurrence of this class in two passes. #3017 corrected a referee test whose comment carried patch C's 37 where the shipped change moves 7. Both are a comment inside the fix quoting the number from before the correction, and both survived review because the number was plausible. Comment-only: `tri seals drift` reads zero across the sealed corpus, so no generated byte moved. FROZEN_HASH resealed in this commit. Refs #2988
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a_loop_without_a_jump_is_unchangedis the test that DEFINES the set a guard-flag change must leave byte-identical. Its comment read "the corpus delta is 37 of 581 generated .v files".37 is patch C's figure — for a change that guarded
returnas well, the half deliberately cut before landing in #3014. What shipped moves 7, re-measured by two independent readers, and #3014's own5063edb19re-sealed 19 seals over exactly those 7 specs.The same sentence also listed
returnamong the statements the fixture avoids. The shipped guard does not know aboutreturnat all — that is #2989 and it is not landed.Found by the judge of a design fan-out on #2989, which read the referee test before proposing to change what it guards. A stale number inside the comment of the test that defines an untouched population is the exact shape this repository has a section about; corrected in place with the reason, not left beside a newer one.
Comment only. No emitted byte moves, so
tri seals driftreads 0; theFROZEN_HASHreseal is the M5 freeze and nothing else.cargo test --release --bin t27c: 1671 passed, 0 failed.Refs #2988
Refs #2989