docs(skill): "19 against 20" is 19 against 21 at the commit that shipped it - #3048
Merged
Conversation
…ped it Section 465 and the body of the pull request carrying it both said: same tree, same command, `find` against `match_indices` -- 19 against 20. At d448b18, the commit that shipped them, it is 19 against 21. Not the instrument, and not a population from outside. Section 465 itself carries the shape it documents: it quotes section 439 -- "reads the last COMMIT message" before "the last 20 commit messages on master" -- so under the old `find` it would have been masked too, and it is the second masked section the fixed rule now sees. The order was: take the reading, write the section, ship. The reading described the tree before the section existed, and it was published as a description of the tree that shipped. That is section 457 word for word -- the figure moved because writing it moved the population -- unlearned one pass after being written, by the author, in the section that cites it. Two things made the gap findable and only one was mine. The number was re-taken by a fan-out told to attack the previous pass's own figures. And the anchor in the pull request body was the words "same tree" rather than a sha: had it named cfa3287 the pair would have been exactly right and merely stale, instead of wrong about the commit it shipped in. "Same tree" does not name a tree. Section 465 is corrected in place. The rule that follows is mechanical: a figure describing the state AFTER a change is taken as the LAST action before the commit, from the tree that is committed, and written with that commit's sha. Applied here: 25 windowed of 434 sections, read from this tree after the last edit to it. Skill section 470. Refs #2994
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
§465 and the body of the PR carrying it both said: same tree, same command,
findagainstmatch_indices— 19 against 20. Atd448b1864, the commit that shipped them, it is 19 against 21.Not the instrument, and not a population from outside. §465 itself carries the shape it documents. It quotes §439 — "reads the last COMMIT message" before "the last 20 commit messages on master" — so under the old
findit would have been masked too, and it is the second masked section the fixed rule now sees.The order was: take the reading, write the section, ship. The reading described the tree before the section existed, and it was published as a description of the tree that shipped.
That is §457 word for word — the figure moved because writing it moved the population — unlearned one pass after being written, by the author, in the section that cites it.
Two things made the gap findable, and only one was mine
cfa32871cthe pair would have been exactly right and merely stale, instead of wrong about the commit it shipped in. "Same tree" does not name a tree.§465 is corrected in place. The rule that follows is narrow and mechanical: a figure describing the state AFTER a change is taken as the last action before the commit, from the tree that is committed, and written with that commit's sha. Any earlier reading describes a different tree, however few minutes earlier it was.
Applied here, and verified after the final edit: 25 windowed of 434 sections, read from this tree.
cargo test -p tri— 534 passed, 0 failedRefs #2994