Skip to content

fix: unbreak master -- 926 drifted seals and a ledger entry that outlived its failure - #2909

Merged
gHashTag merged 4 commits into
masterfrom
w743
Aug 29, 2026
Merged

fix: unbreak master -- 926 drifted seals and a ledger entry that outlived its failure#2909
gHashTag merged 4 commits into
masterfrom
w743

Conversation

@gHashTag

Copy link
Copy Markdown
Owner

seal-coverage on master:

29 failure
 5 success      <- last green: 588074ce, 18:23
 6 failure

First red is d7ee76d4#2866, mine — which changed four emitters, so
generated output moved while the specs did not. The coverage check was
already fail on that PR when I merged it.
Four hours of both sessions' PRs
have carried a red coverage unrelated to whatever they changed.

Before re-sealing, the reading the gate asks for

Re-sealing is a STATEMENT that the new output is the one you want, so read the
acceptance columns first

corpus ratchet, master, latest:
  UNEXPECTED PASSES  : 1
  DISCARD WORSENED   : 0
  GATE FAILURES      : 0

corpus-ratchet is red on an improvement — one more spec passes than the
ledger expects. Nothing worsened. Acceptance is better than what is recorded, so
this records outputs whose acceptance rose.

That ledger entry (151 → 150) is the parallel session's #2906 and is not
touched here.

The change

tri seals drift --fix — 926 files under .trinity/seals, no source changes.

before after
gen-drift seals 926 0
check_seal_coverage.py exit 1 exit 0
seals holding 1224 of 1318
known-broken (pre-existing baseline) 94 94

--self-check still exits 0, so the green is the gate working rather than the
gate skipped.

Closes #2908

…29 runs

`seal-coverage` last passed on master at 588074c, 18:23. The first red is
d7ee76d -- #2866, mine -- which changed four emitters, so generated output moved
while the specs did not.

The `coverage` check was already failing on PR #2866 when I merged it.

Twenty-nine runs later the drift is cumulative:

    926 seals [gen-drift]
      926  gen_hash_rust
       62  gen_hash_verilog
       33  gen_hash_zig
       31  gen_hash_c

The gate calls re-sealing a STATEMENT that the new output is wanted and says to
read the acceptance columns first. Read:

    corpus ratchet, master:  UNEXPECTED PASSES 1
                             DISCARD WORSENED  0
                             GATE FAILURES     0

Red on an improvement -- one more spec passes than the ledger expects, nothing
worsened. Acceptance is better than what is recorded, so this records outputs
whose acceptance rose. That ledger entry (151 -> 150) belongs to the parallel
session's #2906 and is not touched here.

After: 1318 seals, 1224 hold, 94 known-broken already in seal_baseline.txt.
`check_seal_coverage.py` exits 0, and its --self-check still exits 0, so the
green is the gate working rather than the gate skipped.

Closes #2908
@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-29 22:38:59 UTC

Summary

Status Count
Total Open PRs 12
PRs with Failing Checks 10
PRs with All Checks Green 2
READY 0
FAILING 10
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=eec367a5997f != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

…ith it

The second of master's two red gates, and like the first it is not a regression.

    --- Ratchet (W628) ---
      ledger:              151 / 151 cap
      observed (primary):  150
      UNEXPECTED FAILURES: 0
      UNEXPECTED PASSES  : 1
        - specs/pins/emitter_xdc.t27 [typecheck] (fixed -- remove from the ledger)

#2906 fixed it: an integer literal above i64::MAX fell to the float branch, so a
bit mask read as a float initialising an integer. The spec typechecks; the ledger
entry outlived the failure it recorded, and the ratchet named the repair itself.

`max_entries` drops with the entry rather than staying at 151, so the slack
cannot hide the next one. The reason is written into the file beside the number.

Refs #2908
@gHashTag gHashTag changed the title fix(seals): re-seal 926 gen-drifted specs -- master has been red for 29 runs fix: unbreak master -- 926 drifted seals and a ledger entry that outlived its failure Aug 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-29 22:41:27 UTC

Summary

Status Count
Total Open PRs 11
PRs with Failing Checks 10
PRs with All Checks Green 1
READY 0
FAILING 10
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=82e020cf95b2 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-29 22:47:13 UTC

Summary

Status Count
Total Open PRs 12
PRs with Failing Checks 9
PRs with All Checks Green 3
READY 1
FAILING 9
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=82e020cf95b2 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-29 22:57:47 UTC

Summary

Status Count
Total Open PRs 11
PRs with Failing Checks 10
PRs with All Checks Green 1
READY 0
FAILING 10
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=82e020cf95b2 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag merged commit cd2c0d5 into master Aug 29, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

master has been red on seal-coverage for 29 consecutive runs; the PR that started it was merged with that check already failing

1 participant