Handle empty facility type selection in filters correctly#1082
Merged
Conversation
Previously, when no facility types were selected in the filter specification (e.g., for an export), the query would inadvertently return no results. This update initializes `FacilityTypeId` to an empty list and ensures that an empty list bypasses the filter, allowing all facility types to be included. This resolves an issue with the Excel export button where no data was returned if the facility type filter was empty.
tom-karasch
added
bug
Adjust `FacilityNumberExists` and `FacilityEditDto` test cases to pass `FacilityTypeId`. This ensures tests properly validate facility numbers as unique within a specific facility type, aligning with the updated business logic.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when no facility types were selected in the filter specification (e.g., for an export), the query would inadvertently return no results. This update initializes
FacilityTypeIdto an empty list and ensures that an empty list bypasses the filter, allowing all facility types to be included. This resolves an issue with the Excel export button where no data was returned if the facility type filter was empty.