fix(design): disclose OpenAI key source#1278
Open
jbetala7 wants to merge 1 commit intogarrytan:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1248
Summary
~/.gstack/openai.jsonfirst, thenOPENAI_API_KEYOPENAI_API_KEYmatches.env/.env.localin the current directory, so users can see when a project-local key may be used for billingresolveApiKey()backward-compatible while adding source-aware auth metadata and testsRoot cause
Bun can populate
process.env.OPENAI_API_KEYfrom the current working directory's.envbefore gstack's auth resolver runs. The resolver then treated that value like any other environment variable, so design generation gave no clue that billing might hit a project-specific OpenAI account.Testing
bun test design/test/auth.test.tsbun test design/test/auth.test.ts design/test/gallery.test.tsNotes
I also attempted the broader local design test command including
serve.test.tsandfeedback-roundtrip.test.ts; this worktree hit unrelated environment failures (Bun.serve({ port: 0 })failed to bind, andplaywrightwas not resolvable fromfeedback-roundtrip.test.ts). The focused auth coverage and existing gallery tests pass.Need help on this PR? Tag
@codesmithwith what you need.