feat: implement HostConfig for Pi Agent#1289
Open
blaise-liu-optimizely wants to merge 3 commits intogarrytan:mainfrom
Open
feat: implement HostConfig for Pi Agent#1289blaise-liu-optimizely wants to merge 3 commits intogarrytan:mainfrom
blaise-liu-optimizely wants to merge 3 commits intogarrytan:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a new Pi Agent host integration to the existing declarative GStack host-config system, enabling generation/installation behaviors to be driven by HostConfig alongside the other supported hosts.
Changes:
- Added a new
HostConfigdefinition for thepihost. - Registered the new host in the host registry and adjusted the host-count test.
- Updated
.gitignoreto exclude generated Pi artifacts.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
hosts/pi.ts |
Introduces the Pi host configuration (paths, rewrites, runtime assets, install strategy). |
hosts/index.ts |
Registers the Pi host in ALL_HOST_CONFIGS. |
test/host-config.test.ts |
Updates the registry host-count assertion to include the new host. |
.gitignore |
Ignores .pi/ generated artifacts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds formal host support for the Pi Agent (
@mariozechner/pi-coding-agent) within the GStack framework. Following the guidelines indocs/ADDING_A_HOST.md, this integration allows Pi Agent users to leverage GStack's multi-persona agentic workflows.Key Changes:
hosts/pi.tsto define theHostConfigfor Pi, mapping global and local skill roots to~/.pi/agent/skills/gstack.hosts/index.ts..gitignoreto exclude the.pi/directory to prevent tracking generated skill artifacts.test/host-config.test.tsto include validation for the new Pi host configuration.Verification:
The following local validations were performed using Bun to ensure framework stability:
bun run scripts/host-config-export.ts validateto confirm the configuration matches the expected interface.bun run gen:skill-docs --host pisuccessfully generates host-specific skill documentation.bun test test/host-config.test.tsandbun test test/gen-skill-docs.test.tswith all tests passing.Close #1288 .
Need help on this PR? Tag
@codesmithwith what you need.