Skip to content

Custom Stream Creation #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxwalley wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Custom Stream Creation #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1fa0906
ZeroTimeStamp period now sticks to sample rate if it originally is se…
maxwalley Mar 19, 2026
2b8d6b9
Added virtual method for creating streams
maxwalley Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions include/aspl/Device.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,6 +1202,8 @@ class Device : public Object

//! @}

virtual std::shared_ptr<Stream> CreateStream(const StreamParameters& params);

private:
// value checkers for async setters
OSStatus CheckNominalSampleRate(Float64 rate) const;
Expand All @@ -1223,6 +1225,7 @@ class Device : public Object
std::atomic<UInt32> latency_;
std::atomic<UInt32> safetyOffset_;
std::atomic<UInt32> zeroTimeStampPeriod_;
const bool zeroTimeStampPeriodBasedOffSampleRate_;
std::atomic<Float64> nominalSampleRate_;

std::atomic<SInt32> startCount_ = 0;
Expand Down
14 changes: 12 additions & 2 deletions src/Device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ Device::Device(std::shared_ptr<const Context> context, const DeviceParameters& p
, safetyOffset_(params.SafetyOffset)
, zeroTimeStampPeriod_(
params_.ZeroTimeStampPeriod ? params_.ZeroTimeStampPeriod : params_.SampleRate)
, zeroTimeStampPeriodBasedOffSampleRate_(!params_.ZeroTimeStampPeriod)
, nominalSampleRate_(params.SampleRate)
, preferredChannelsForStereo_({1, 2})
{
Expand Down Expand Up @@ -162,6 +163,11 @@ OSStatus Device::SetNominalSampleRateImpl(Float64 rate)
{
nominalSampleRate_ = rate;

if(zeroTimeStampPeriodBasedOffSampleRate_)
{
SetZeroTimeStampPeriodImpl(rate);
}

return kAudioHardwareNoError;
}

Expand Down Expand Up @@ -500,8 +506,7 @@ std::shared_ptr<Stream> Device::AddStreamAsync(Direction dir)

std::shared_ptr<Stream> Device::AddStreamAsync(const StreamParameters& params)
{
auto stream = std::make_shared<Stream>(
GetContext(), std::static_pointer_cast<Device>(shared_from_this()), params);
auto stream = CreateStream(params);

AddStreamAsync(stream);

Expand Down Expand Up @@ -1578,6 +1583,11 @@ OSStatus Device::EndIOOperation(AudioObjectID objectID,
return status;
}

std::shared_ptr<Stream> Device::CreateStream(const StreamParameters& params)
{
return std::make_shared<Stream>(GetContext(), std::static_pointer_cast<Device>(shared_from_this()), params);
}

OSStatus Device::EndIOOperationImpl(UInt32 clientID,
UInt32 operationID,
UInt32 ioFrameCount,
Expand Down
Loading