fix: remove 2-min exec timeout that orphans mine processes - #4
Open
atsyongki wants to merge 1 commit into
Open
Conversation
The exec() timeout of 120s killed only the wrapper shell when 'mempalace mine' exceeded 2 minutes on a large palace, orphaning the python mine process which kept running and holding the palace lock. miningLock was released early via the error callback, letting duplicate concurrent mines pile up and contend for the lock, which also blocked repair commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
exec()call that runsmempalace minehastimeout: 120000. On a large palace (tens of thousands of drawers), a mine legitimately takes longer than 2 minutes. When the timeout fires:mempalace minepython process is orphaned and keeps running, still holding the palace lock.miningLock = false.Fix
Remove the arbitrary timeout.
miningLockalready serializes concurrent mines; the timeout only made things worse by orphaning processes and breaking that serialization. Long mines now run to completion; the exported session files are cleaned up in the success path as before.Verification
PPID 1).