fix(daily-stats-email): static subject/title (drop event.date)#11
Closed
pigri wants to merge 1 commit into
Closed
Conversation
The parameter-template expr engine has no way to guard a missing map key
(no ternary/??/in), so subject + title referencing ${inputs.event.date}
hard-fail ("key date not found") on any run without the event payload
(e.g. a manual rerun). Make them static; the daily date is still implied
by the send date and the full stats remain in the body (rendered by the
tolerant data.template Go renderer).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The param-template expr engine (deepnoodle-ai/expr) supports no conditional/guard (no ternary,
??,?.,in,get), and any access to a missing map key errors. Sosubject/titlereferencing${inputs.event.date}hard-fail withkey "date" not foundon any run lacking the event payload (manual rerun). Make them static. The full stats body is unaffected (rendered by data.template's Go html/template, which tolerates missing keys). Existing install will be patched in workflow_prod (both definition + published_definition).