feat: ndvi from stac by michaelmattig · Pull Request #11 · geo-engine/BioIS

michaelmattig · 2026-03-20T15:19:09Z

No description provided.

coveralls · 2026-03-20T15:25:22Z

coverage: 80.578% (+0.7%) from 79.899% — ndvi-stac into main

ChristianBeilschmidt · 2026-03-20T16:09:25Z

Habe ich einen gedanklichen Fehler, oder wäre die Config nicht

[geoengine]
base_url = "https://geoengine.biois.app.geoengine.io/api"

?

Der Fehler ist

2026-03-20T16:16:45.406573Z ERROR ogcapi_services::error: Generic error: Failed to perform OIDC login

Caused by:
error in response: status code 400 Bad Request

2026-03-20T16:16:45.406993Z ERROR tower_http::trace::on_failure: response failed, classification: Status code: 500 Internal Server Error, latency: 48 ms
at /home/beilschmidt/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tower-http-0.6.8/src/trace/on_failure.rs:93
in tower_http::trace::make_span::request with method: POST, uri: /auth/accessTokenLogin?redirectUri=http%3A%2F%2Flocalhost%3A4200%2Fapp%2Fsignin, version: HTTP/1.1

michaelmattig · 2026-03-24T15:20:31Z

Habe ich einen gedanklichen Fehler, oder wäre die Config nicht
[geoengine]
base_url = "https://geoengine.biois.app.geoengine.io/api"
?

Der Fehler ist

2026-03-20T16:16:45.406573Z ERROR ogcapi_services::error: Generic error: Failed to perform OIDC login

Caused by:
error in response: status code 400 Bad Request

2026-03-20T16:16:45.406993Z ERROR tower_http::trace::on_failure: response failed, classification: Status code: 500 Internal Server Error, latency: 48 ms
at /home/beilschmidt/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/tower-http-0.6.8/src/trace/on_failure.rs:93
in tower_http::trace::make_span::request with method: POST, uri: /auth/accessTokenLogin?redirectUri=http%3A%2F%2Flocalhost%3A4200%2Fapp%2Fsignin, version: HTTP/1.1

nö ist richtig. bei mir funktioniert es aber auch

ChristianBeilschmidt · 2026-03-25T10:46:44Z

Vielleicht kannst du meinen User noch mal aus der DB löschen? Irgendwas muss ja falsch sein.

ChristianBeilschmidt · 2026-04-21T05:57:38Z

+ */
+
+import { PointGeoJsonInput } from '../models/PointGeoJsonInput';
+import { HttpFile } from '../http/http';


Kann man den Bot davon abbringen im generierten Code missing imports zu suchen?

geht glaube ich mit ner codeql.yml https://docs.github.com/en/code-security/reference/code-scanning/workflow-configuration-options

ChristianBeilschmidt · 2026-04-21T06:00:08Z


  readonly processId: Signal<string | undefined>;

+  private readonly mockInputs: NDVIProcessOutputs = {


Wieso mock?

das ist ein Placeholder. s.u. warum das nicht mehr leer sein darf.

ChristianBeilschmidt · 2026-04-21T06:00:39Z

      processId: this.processId(),
    }),
-    defaultValue: {},
+    defaultValue: this.mockInputs,


Wieso kann das nicht erst einmal leer sein?

bisher war alles optional. jetzt gibt es die input-Outputs (der Punkt für den NDVI berechnet werden soll) immer. daher ist ein leeres Objekt jetzt kein gültiges Result mehr.

ChristianBeilschmidt · 2026-04-21T06:02:03Z

+      // Transform Results (with InlineOrRefData wrappers) to NDVIProcessOutputs
+      const outputs: NDVIProcessOutputs = {
+        ndvi: null,
+        kNdvi: null,
+        inputs: this.mockInputs.inputs,
+      };
+
+      // Extract values from InlineOrRefData wrappers
+      if ('ndvi' in result) {
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
+        const ndviData = result['ndvi'];
+        outputs.ndvi = typeof ndviData === 'number' ? ndviData : null;
+      }
+      if ('kNdvi' in result) {
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
+        const kNdviData = result['kNdvi'];
+        outputs.kNdvi = typeof kNdviData === 'number' ? kNdviData : null;
+      }
+      if ('inputs' in result) {
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
+        const inputsData = result['inputs'];
+        // Extract the value from QualifiedInputValue wrapper
+        if (this.isQualifiedInputValue(inputsData) && inputsData.value) {
+          outputs.inputs = inputsData.value as typeof outputs.inputs;
+        }
+      } else {
+        throw new Error('Expected "inputs" in result but it was missing');
+      }


wieso muss man das auf einmal so komisch auspacken?

wenn man das result einfach so rausgeben versucht kommt dieser Fehler

✘ [ERROR] TS2322: Type 'ResourceRef<NDVIProcessOutputs | { [key: string]: any; }>' is not assignable to type 'ResourceRef<NDVIProcessOutputs>'. Type 'NDVIProcessOutputs | { [key: string]: any; }' is not assignable to type 'NDVIProcessOutputs'. Property ''inputs'' is missing in type '{ [key: string]: any; }' but required in type 'NDVIProcessOutputs'. [plugin angular-compiler] src/app/result/result.component.ts:68:11: 68 │ readonly result: ResourceRef<NDVIProcessOutputs> = resource({ ╵ ~~~~~~ ''inputs'' is declared here. ../api-client/typescript/dist/models/NDVIProcessOutputs.d.ts:5:4: 5 │ 'inputs': NDVIProcessInputs; ╵ ~~~~~~~~

das Problem ist irgendwie dass dieses result hier:

const result = await api.results(params.processId);

so definiert ist:

export type Results = HttpFile | { [key: string]: InlineOrRefData; };

und da fehlt dann halt der Input-Output

warum ist das eigentlich nicht typisiert? Wir haben doch alles OpenAPi spezifiziert? Kannst du mir da helfen?

habe hier noch mal versucht das etwas cleaner zu gestalten: cd116ed

ChristianBeilschmidt · 2026-04-21T06:02:39Z

+  private isQualifiedInputValue(data: InlineOrRefData): data is QualifiedInputValue {
+    return typeof data === 'object' && data !== null && 'value' in data;
+  }


Was genau ist qualified?

das ist von OGC API Processes. Der Input im Output ist ja ein Objekt:

BioIS/backend/src/processes/ndvi.rs

Line 87 in 46ae1af

data: InlineOrRefData::QualifiedInputValue(QualifiedInputValue {

. Und in den OGC ExecuteResults ist ein Feld entweder ein InputValueNoObject wenn es kein Object ist oder wenn es ein Object ist dann QualifiedInputValue? Vielleicht missverstehe ich das aber auch. Korrigier mich gerne.

michaelmattig changed the title ~~ndvi from stac~~ feat: ndvi from stac Mar 20, 2026

ndvi from stac

a3db010

michaelmattig force-pushed the ndvi-stac branch from adc243b to a3db010 Compare March 20, 2026 15:38

clippy

3e1c4e8

ChristianBeilschmidt requested changes Apr 2, 2026

View reviewed changes

Comment thread backend/src/util.rs

Comment thread backend/src/util.rs

Comment thread backend/src/util.rs

michaelmattig added 4 commits April 2, 2026 14:32

fix coordinate and date input

cbcc137

Merge branch 'main' of github.com:geo-engine/BioIS into ndvi-stac

f534858

more UI fixes

9aebbd8

update openapi enum name

f7caaf8

ChristianBeilschmidt approved these changes Apr 10, 2026

View reviewed changes

ChristianBeilschmidt requested changes Apr 10, 2026

View reviewed changes

Comment thread backend/src/processes/ndvi.rs

Comment thread backend/src/processes/ndvi.rs

ChristianBeilschmidt requested changes Apr 14, 2026

View reviewed changes

Comment thread backend/Cargo.toml Outdated

improve error messages

d60089b

github-code-quality Bot found potential problems Apr 16, 2026

View reviewed changes

add inputs to outputs

46ae1af

michaelmattig force-pushed the ndvi-stac branch from 8a85906 to 46ae1af Compare April 16, 2026 15:46

ChristianBeilschmidt requested changes Apr 21, 2026

View reviewed changes

Comment thread backend/src/processes/ndvi.rs Outdated

ChristianBeilschmidt requested changes Apr 21, 2026

View reviewed changes

michaelmattig added 3 commits April 21, 2026 09:27

improve error message

1c6a2d3

update api-client dependency

c613b7b

openapi schema for Results

cd116ed


		readonly processId: Signal<string \| undefined>;

		private readonly mockInputs: NDVIProcessOutputs = {

Conversation

michaelmattig commented Mar 20, 2026

Uh oh!

coveralls commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChristianBeilschmidt commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michaelmattig commented Mar 24, 2026

Uh oh!

ChristianBeilschmidt commented Mar 25, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michaelmattig Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michaelmattig Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coveralls commented Mar 20, 2026 •

edited

Loading

ChristianBeilschmidt commented Mar 20, 2026 •

edited

Loading

michaelmattig Apr 21, 2026 •

edited

Loading

michaelmattig Apr 21, 2026 •

edited

Loading