Complete sidebar hierarchy, menus, and row alignment - #2501
Open
brsbl wants to merge 16 commits into
Open
Conversation
# Conflicts: # packages/domain/src/plugin-sdk-version.ts # packages/plugin-sdk/package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
The composed sidebar stack still had inconsistent ownership at its integration edge. Plugin rows did not expose the complete host-owned action set, the major sidebar regions could not be reordered together, thread-list controls and labels changed structure between organization modes, and row status, caret, and hover-action slots did not stay aligned across collapsible row families.
The integration pass also left two state-semantics defects: Organize behaved like three independent toggles, and a sort-only change incorrectly made the Filter button look active.
What changed
Compatibility correction
Commit
6e2e61ab502ca4eb79b8a52e5763a095ef40484arestores the Plugin SDK version files to the parent layer's0.4.24. The cumulative PR diff no longer changespackages/domain/src/plugin-sdk-version.tsorpackages/plugin-sdk/package.json.Visual evidence
All pairs compare exact parent head
66cf39b68e813c195e39ecdb022cb5ffbf0292c5with exact PR head75ae227eaf74329716387e5b57c4ef0c5caf953b. They use the same copied SQLite, auth, and populated Docs-plugin fixture, route, light theme, 1440×900 viewport, and 320×900 sidebar crop.Project organization
Before — parent head: the populated Plugins region is present, but the thread list has no Projects label row or persistent controls.
After — PR head: Plugins remains populated, and Projects now owns the persistent Organize, Filter and sort, New thread, and overflow controls.
Custom sections
Before — parent head: the Docs plugin page, manual section, and loose threads are visible, but there is no Sections label row or persistent control cluster.
After — PR head: Sections owns the persistent controls; the manual section and loose threads remain below it without a misleading extra top-level label.
Machine organization
Before — parent head: the Docs plugin page and machine group are visible, but there is no Machines label row or persistent controls.
After — PR head: Machines owns the same persistent Organize, Filter and sort, New thread, and overflow control cluster.
How you verified
scripts/bb-dev-app currentKnown coverage limits: the shipped fixture exposes five traditional non-Automations plugin pages, so the six-page overflow threshold is regression-test-covered rather than reproduced in the app. Draft deletion, archived pagination sentinel loading, and draft-destination persistence were not explicitly completed in this pass. Later command-palette visual work (including empty-query Backspace, empty Plugins-heading suppression, and scroll fade) is not part of this registered stack.
Fixes: N/A — Updated Sidebar final integration layer.
BB-Thread-ID: thr_2e2gbjx943