Clarify worktree, machine, and Git context - #2711
Open
brsbl wants to merge 19 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
On
main, thread context mixes the worktree resource with its machine and locality, while Diff does not identify the branch or commit behind the changes. Generated worktree identifiers are unreadable, but substituting a machine name can make a managed worktree look like a direct machine workspace. The affected tooltips also repeat taxonomy or include parenthetical shortcut copy.What changed
Composer
Machine.Offline, only a truncated machine name exposes the full name, the generic machine icon has no redundant tooltip or focus stop, and the worktree icon retains itsWorktreetooltip.Project:/Machine:prefixes only from the affected Composer tooltips.Info
WorktreeandMachinerows. A missing custom worktree name appears asUnnamed; supporting labels arePath,Base, andStatus.Add nameactions, and this PR does not change rename persistence, permissions, validation, or behavior.Diff and shared Git context
Detached at <sha>above the Diff selector without a genericBranchorCheckoutheading.Coverage and boundaries
Screenshots
Historical references — replacement required
The four embedded images below are retained only as historical references. They are not final comparison evidence: the pairs use different threads, content, repository state, and panel state, and the after images predate the current PR head.
Composer context
Before reference — source revision is not recorded in the attachment
After reference — branch revision
14d130ad5, not the current headDiff branch and commit context
Before reference — source revision is not recorded in the attachment
After reference — branch revision
14d130ad5, not the current headBefore merge, replace each pair with the same fixture, route, interaction state, and 1440×900 viewport captured from merge base
f4bbc2fe81a9b7639ff9a7396e172bddd89109e4for before and exact PR head538bf478b9e81ea4cb1432acf1789b1f481eaf76for after.How you verified
538bf478b9e81ea4cb1432acf1789b1f481eaf76.Offlineappears only from the issue icon, the full machine name appears only from the name target, direct machine icons have noMachinefocus target, worktree icons retain theirWorktreetarget, Diff contains noCheckoutheading, and the detached value readsDetached at abcdef1.BB-Thread-ID: thr_5vi3d8bpih