Replace compact overlays with persistent shelves - #2761
Merged
brsbl merged 18 commits intoSep 1, 2026
Merged
Conversation
brsbl
marked this pull request as ready for review
August 31, 2026 05:56
This was referenced Aug 31, 2026
brsbl
force-pushed
the
bb/compact-mobile-shelves-thr_wftu7bh9ez
branch
from
September 1, 2026 04:41
5bf09cb to
8bd2014
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
On compact viewports, the left navigation covered and dimmed the page, while the right panel rose as a dimmed bottom drawer. Both overlays hid the surface users were navigating from and made the product feel like disconnected modal sheets.
What changed
ThreadSecondaryPanelstory.No full-page tool-tab behavior is introduced in this layer; every right-panel tab still uses the shelf.
How you verified
f65de938732b45cf993ed9fc721264229e0d96b3and then-head991070eab2c60f00fdb242403b38890dffdc852d.4b8a22b0aaada44f118eac54af996db0844d267cand capture head108402ee09e4a70b2df61542e7054ce73fae924a. The final square-pane layer is exact base38c122fc1b74ae4a0afe28596f86e6da9a73aa48and exact head8bd201435a25ce4feb3579a5fe3b9fa84d22e4b6.Start terminalaction. Both captured subtrees had zero loading skeletons.Hide right panelinthread-secondary-panel-top-chrome. The fixed left trigger was absent from the DOM and focus order; closing the panel restored it, and opening the left shelf kept the right shelf closed.Left navigation: modal drawer → persistent shelf
Right panel: bottom drawer → persistent right shelf
Square shelf edges before the toggle-ownership fix
The earlier before/after captures document the drawer-to-shelf change at their labeled capture heads. The square-pane captures below come from the preceding head; the final toggle-only update leaves this geometry unchanged.
One compact sidebar control at a time
The preceding #2761 head correctly suppressed translated workspace actions but still showed the fixed left trigger beside the right shelf owned control. At the exact final head, the fixed trigger leaves the DOM and focus order while the right shelf is active. Closing the right shelf restores it; opening the left shelf keeps the right shelf closed and leaves only the left trigger on screen.
BB-Thread-ID: thr_wftu7bh9ez