Open compact tool tabs as full-page surfaces - #2762
Open
brsbl wants to merge 18 commits into
Open
Conversation
brsbl
marked this pull request as ready for review
August 31, 2026 05:56
This was referenced Aug 31, 2026
# Conflicts: # apps/app/src/components/ui/sidebar.test.tsx # apps/app/src/components/ui/sidebar.tsx
…ct-tool-tabs-full-page-thr_wftu7bh9ez
…ct-tool-tabs-full-page-thr_wftu7bh9ez
…ct-tool-tabs-full-page-thr_wftu7bh9ez
…ct-tool-tabs-full-page-thr_wftu7bh9ez
…ct-tool-tabs-full-page-thr_wftu7bh9ez # Conflicts: # apps/app/src/components/secondary-panel/CompactSecondaryPanelShelf.tsx
…ct-tool-tabs-full-page-thr_wftu7bh9ez
…ct-tool-tabs-full-page-thr_wftu7bh9ez
…ct-tool-tabs-full-page-thr_wftu7bh9ez
…ct-tool-tabs-full-page-thr_wftu7bh9ez
…ct-tool-tabs-full-page-thr_wftu7bh9ez
…ct-tool-tabs-full-page-thr_wftu7bh9ez
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
After the right panel became a shelf, every tab remained constrained to 298.67px. Selecting New Tab could update the tab strip while leaving Info content visible, so tool surfaces did not receive a usable phone-width canvas. A newly created terminal could also lose its persisted active selection while the terminal list caught up, causing the settled tab to fall back to the shelf.
What changed
Compact presentation rules
The opener only selects or restores a tab. The active tab kind determines the panel geometry, and switching tabs changes that geometry immediately.
thread-info)No mobile-home, navigation-feedback, provider-cache, or base shelf behavior changes in this layer.
How you verified
ddaf081641b863e5c060f5bb5b5690439aaa3b7cand exact final headf06a2a7be2676edc878bc5808ae896a22784cca4.Start terminaland waited for the realzshtab and xterm subtree to settle with zero panel skeletons./projects/proj_m65y3vujaj/threads/thr_done, using one realistic environment-backed fixture, the same persistedAppPageHeader.tsxtab, the same populated Recent item, and the same viewport for both current-head captures. Only the active tab changed.Current-head behavior: Info versus New Tab
The original evidence followed
New Tab→Start terminaland captured the terminal endpoint. It proved that a non-Info tab became full-page, but Info was never selected, so the unchanged shelf exception was missing from the evidence.Original base/head width regression
This historical pair remains the original feature regression; the current-head pair above is the final-branch evidence.
BB-Thread-ID: thr_wftu7bh9ez