yield: group commit attribution by canonical repo root (fixes #713)#719
Merged
Conversation
Sessions launched from monorepo subdirectories or separate worktrees of one repository formed independent attribution groups, each awarding the same commit (double-counted productive sessions; the duplicate owner was not even flagged ambiguous). Groups now key on the realpath of git-common-dir, so all subdirs and worktrees of a repo collapse into one group while distinct repos stay separate; ambiguity semantics unchanged, now correctly spanning the whole repo. rev-parse results cached per directory. Fixes #713. Regression tests fail on the unfixed code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Monorepo subdirs and worktrees of one repo each pulled the identical repo-wide commit list and independently awarded the same commit. Groups now key on realpath'd git-common-dir (worktrees unify; separate repos stay separate). Regression tests verified to fail on unfixed main: two-subdir and two-worktree cases both double-credited before, single-credit after; separate-repo guard included.
Fixes #713.