v3 by kmendell · Pull Request #4523 · getarcaneapp/arcane

kmendell · 2026-10-21T02:47:38Z

Caution

This branch has breaking changes.

You can test it with the getarcaneapp/manager:v3-beta and getarcaneapp/agent:v3-beta images, but beware you have been warned.

Disclaimer Greptiles Reviews use AI, make sure to check over its work.

To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike

To have Greptile Re-Review the changes, mention greptileai.

Confidence Score: 4/5

Fix the inspector's missing activity output before merging; the upgrade dialog also needs to adopt later job updates.

Findings

Selected activity output stays empty ▶
Running upgrades stay hidden ▶

Fix with agent prompt

### Issue 1
frontend/src/lib/components/activity/activity-center-inspector.svelte:17-18
Opening the inspector without an explicit selection now displays the first activity without calling `activityStore.focus()`. That call used to start `loadDetailInternal()`. `ActivityDetailView` only reads cached details, and incoming messages are ignored until that cache entry exists. An activity whose details have not been loaded therefore shows empty output even when it has logs, until the user clicks it.

Keep the derived selection, but also load details when the displayed key changes.

### Issue 2
frontend/src/lib/components/dialogs/update-all-dialog.svelte:86-92
The dialog now adopts an existing job only during its first status request. If that request fails, or another tab starts an upgrade afterward, `watch()` still updates `upgradeJobStore.job` but nothing sets `jobId`. The dialog stays on the confirmation screen and hides progress and results until the user reopens it or confirms again.

Derive the displayed job from the live store until an explicit job has been selected, or adopt it when an update arrives.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

This v3 PR reorganizes the backend, shared types, agent connections, and frontend. The latest patch addresses all five numbered findings.

The manager sends environment requests through agent tunnels with the caller’s permissions.
Upgrade jobs show progress across environments, and the dashboard uses configurable widgets.
Image details can show release notes from the image’s source project.

_{Reviews (2) · Last reviewed commit: "chore: cr" · Reviewed by Greptile}

- Drop nil checks on injected services in auth, event, federated, registry, image update tags, and agent bootstrap - Drop the nil fallbacks in tag registry lookups, using the settings-driven digest timeout directly - Remove inline doc comments that restated the code, and tighten the remaining ones - Bump docker/compose/v5 to v5.7.0 with containerd v2.4.2 and go-winio v0.6.4 - Drop unused eiannone/keyboard and skratchdot/open-golang modules; add docker/secrets-engine as indirect deps

- Move buttons, inputs, selects, and tab pills to xl radii with lighter tinted badges - Add an underline tab variant for page-level tab bars - Shorten digests with a copy button and split port badges into host and container parts - Show stopped and exited containers as gray, not red - Add an optional segment bar to stat strip items

- Agents send hostname, OS, kernel, architecture, Docker and agent versions, CPUs, and memory when they register - Manager tracks tunnel RTT min/avg/max, bytes in/out, and stream counts - Manager keeps per-environment session count and last disconnect reason - Environment runtime state exposes agentHost and agentTunnelStats - Tunnel remote address honors trusted proxies via X-Forwarded-For

- Switch IsDiscovered, HasBuildDirective, RedeployDisabled, and EnvFileExists from omitempty to omitzero in types/project.go - Aligns the project flags with the json v2 zero-value convention used across types/

- Parse PROXY protocol headers on the HTTP listener when ARCANE_TRUSTED_PROXIES is set - Headers from trusted ranges set the client address; other peers are unchanged - Invalid trusted proxy ranges log a warning and disable PROXY protocol - Unwrap PROXY protocol connections in httpx so TCP deadline handling still applies

- Layout: fall back to cached or default version info when the version query fails - Layout: treat failed autologin queries as no config instead of throwing - Security: ignore cancelled query errors and default overview to null - Rename the registries page title to "Registries"

- Include the server timezone in job list responses, local and remote - Show the timezone in the environment automations schedule dialog - Log the timezone and UTC offset when the scheduler starts - Embed tzdata so named timezones load without system zoneinfo

- Wake tunnel waiters on registration instead of polling every 100ms - Pool 64 KiB copy buffers; flush only event streams and unknown-length responses - Reuse read buffers for tunnel and WebSocket frames - Stop forwarding the caller's Authorization, API key, and cookie to agents; only the agent token is sent - Add proxy and WebSocket frame benchmarks

- Add POST /api/environments/{id}/tunnel/restart, gated by environments:restart - Add `arcane environments tunnel restart <id>` CLI command - Add Restart Tunnel action on the environment detail page - Record an environment.tunnel.restarted event - Replace setup-go module caching with actions/cache in build and release workflows

- Compare run snapshots by maphash digest instead of retaining full JSON per run - Track pending activity sync per run and keep pending runs across mutations - Split coordinator "replace" into its own path that reads only the revision - Lower Postgres max idle connections from 15 to 4 - Grant environments:restart in RBAC migration 00102 (SQLite and Postgres)

- Load one coordinator record per job for run lists and job status instead of every record - Use lightweight summaries for repair and activity-sync passes instead of full coordinator state - Drop attempts and outcome targets on succeeded, skipped, and canceled runs beyond the 10 most recent detailed runs, keeping up to 50 retained - Exclude those compacted fields from activity digests so compaction does not trigger activity resync

- Drop the child process and its SIGTERM forwarding and exit-status relay - Set supplementary groups, GID, then UID in-process before exec - Set DOCKER_HOST, then syscall.Exec the same binary with the original args

- Use SvelteSet for expanded and selected rows in arcane-table and backup-file-picker - Replace manual grouping loops with Map.groupBy in arcane-table and port-badge - Remove snippet wrappers in gitops, backup policy, image search, and service editor dialogs - Split the API key page description into separate i18n keys so the link can be translated around

- Delete existing files through the workspace API immediately instead of queuing them until save - Keep pending renames, moves, and unsaved creates as local changes - Show a delete toast with the activity ID on success - Use plain Set, Map, and URL where Svelte reactivity is not needed - Update runtime identity spec expectations for PID 1 after exec

- Add an actions/cache step for ~/.local/share/pnpm/store before each Vite+ setup, keyed on runner OS, job, and pnpm-lock.yaml hash - Set cache: false on setup-vp in all jobs so the built-in cache does not overlap the explicit one

- Add optional GitHub token setting to raise the release notes API rate limit - Discover upstream GitHub repos when image labels are missing or point elsewhere - Match prefixed release tags (release-, app-) and find tags beyond the first page of releases - Use the image tag as the running version when no version label is set - Report GitHub rate limits with the reset time in logs - Change workspace delete confirmation to "This cannot be undone."

greptile-apps · 2026-11-04T05:58:40Z

+	const firstGroup = $derived(activityStore.runningGroups[0] ?? activityStore.historyGroups[0]);
+	const selectedKey = $derived(activityStore.focusedKey ?? (firstGroup ? activityGroupKey(firstGroup) : null));


Selected activity output stays empty

Opening the inspector without an explicit selection now displays the first activity without calling activityStore.focus(). That call used to start loadDetailInternal(). ActivityDetailView only reads cached details, and incoming messages are ignored until that cache entry exists. An activity whose details have not been loaded therefore shows empty output even when it has logs, until the user clicks it.

Keep the derived selection, but also load details when the displayed key changes.

Prompt To Fix With AI

This is a comment left during a code review. Path: frontend/src/lib/components/activity/activity-center-inspector.svelte Line: 17-18 Comment: **Selected activity output stays empty** Opening the inspector without an explicit selection now displays the first activity without calling `activityStore.focus()`. That call used to start `loadDetailInternal()`. `ActivityDetailView` only reads cached details, and incoming messages are ignored until that cache entry exists. An activity whose details have not been loaded therefore shows empty output even when it has logs, until the user clicks it. Keep the derived selection, but also load details when the displayed key changes. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

greptile-apps · 2026-11-04T05:58:40Z

+		const current = await upgradeJobStore.load();
 		if (attempt !== startAttempt) return;
-		if (response.error !== null) {
-			handleStatusError(response.error);
+		if (isActiveUpgradeJob(current)) {
+			followJob(current);
 			return;
 		}
-		if (isActiveJob(response.data)) {
-			followJob(response.data);
-		} else {
-			phase = 'confirm';
-		}
+		starting = false;


Running upgrades stay hidden

The dialog now adopts an existing job only during its first status request. If that request fails, or another tab starts an upgrade afterward, watch() still updates upgradeJobStore.job but nothing sets jobId. The dialog stays on the confirmation screen and hides progress and results until the user reopens it or confirms again.

Derive the displayed job from the live store until an explicit job has been selected, or adopt it when an update arrives.

Prompt To Fix With AI

This is a comment left during a code review. Path: frontend/src/lib/components/dialogs/update-all-dialog.svelte Line: 86-92 Comment: **Running upgrades stay hidden** The dialog now adopts an existing job only during its first status request. If that request fails, or another tab starts an upgrade afterward, `watch()` still updates `upgradeJobStore.job` but nothing sets `jobId`. The dialog stays on the confirmation screen and hides progress and results until the user reopens it or confirms again. Derive the displayed job from the live store until an explicit job has been selected, or adopt it when an update arrives. --- For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

kmendell force-pushed the breaking/v3 branch 9 times, most recently from 9636bee to f656b3a Compare October 27, 2026 01:04

kmendell force-pushed the breaking/v3 branch 5 times, most recently from 47a5e0f to 8b586da Compare October 30, 2026 17:18

github-advanced-security Bot found potential problems Oct 30, 2026

View reviewed changes

Comment thread backend/pkg/agent/server.go Fixed

Comment thread backend/pkg/agent/server.go Fixed

Comment thread backend/pkg/agent/server.go Fixed

Comment thread backend/pkg/agent/mux_agent.go Fixed

Comment thread backend/internal/middleware/environment.go Dismissed

kmendell force-pushed the breaking/v3 branch from 0356773 to 78d3e77 Compare October 30, 2026 17:34

github-advanced-security Bot found potential problems Oct 30, 2026

View reviewed changes

Comment thread backend/pkg/ws/proxy.go Fixed

kmendell force-pushed the breaking/v3 branch 5 times, most recently from 94607ff to 7fc6aa9 Compare October 31, 2026 18:50

github-advanced-security Bot found potential problems Nov 1, 2026

View reviewed changes

github-advanced-security Bot found potential problems Nov 3, 2026

View reviewed changes

Comment thread backend/internal/telemetry/module.go Dismissed

Comment thread backend/internal/telemetry/module.go Dismissed

kmendell added 6 commits November 3, 2026 22:05

refactor!: consolidate types into unified package

94c1413

refactor!: remove legacy arcane container images tags

7242793

refactor!: remove mixed-version job run resolution endpoint

10a60d1

refactor!: remove legacy agent-owned run adoption

4790e9c

refactor!: remove legacy remote job resolution protocol

2952f6b

refactor!: remove legacy edge message protocol

f5ffa8e

kmendell added 20 commits November 3, 2026 22:06

chore: bump deps

5267d19

refactor: use omitzero for project read-only flags

17edc97

- Switch IsDiscovered, HasBuildDirective, RedeployDisabled, and EnvFileExists from omitempty to omitzero in types/project.go - Aligns the project flags with the json v2 zero-value convention used across types/

chore: update badge styling

a68d5b5

chore: mirror go types in frontend

00f5d7d

fix: exec runtime identity in place instead of a child process

51f9bb4

- Drop the child process and its SIGTERM forwarding and exit-status relay - Set supplementary groups, GID, then UID in-process before exec - Set DOCKER_HOST, then syscall.Exec the same binary with the original args

ci: cache pnpm store explicitly in workflows

0e30356

- Add an actions/cache step for ~/.local/share/pnpm/store before each Vite+ setup, keyed on runner OS, job, and pnpm-lock.yaml hash - Set cache: false on setup-vp in all jobs so the built-in cache does not overlap the explicit one

chore: merge fixes

3a33149

kmendell force-pushed the breaking/v3 branch from b334b50 to 3a33149 Compare November 4, 2026 04:08

chore: remove beta build for merge prep

e29a35e

kmendell marked this pull request as ready for review November 4, 2026 05:21

kmendell requested a review from a team November 4, 2026 05:21

graphite-app Bot assigned kmendell Nov 4, 2026

greptile-apps Bot reviewed Nov 4, 2026

View reviewed changes

chore: cr

391c015

kmendell merged commit 391c015 into main Nov 4, 2026
18 of 21 checks passed

kmendell deleted the breaking/v3 branch November 4, 2026 05:52

greptile-apps Bot reviewed Nov 4, 2026

View reviewed changes

		const firstGroup = $derived(activityStore.runningGroups[0] ?? activityStore.historyGroups[0]);
		const selectedKey = $derived(activityStore.focusedKey ?? (firstGroup ? activityGroupKey(firstGroup) : null));

Conversation

kmendell commented Oct 21, 2026 • edited by greptile-apps Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 4/5

Findings

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Nov 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kmendell commented Oct 21, 2026 •

edited by greptile-apps Bot

Loading