-
Notifications
You must be signed in to change notification settings - Fork 8
chore(android-kotlin): add integration tests #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,307 @@ | ||||||||
| # | ||||||||
| # .github/workflows/android-kotlin-browserstack.yml | ||||||||
| # Workflow for building and testing android-kotlin on BrowserStack physical devices | ||||||||
| # | ||||||||
| --- | ||||||||
| name: android-kotlin-browserstack | ||||||||
|
|
||||||||
| on: | ||||||||
| pull_request: | ||||||||
| branches: [main] | ||||||||
| paths: | ||||||||
| - 'android-kotlin/**' | ||||||||
| - '.github/workflows/android-kotlin-browserstack.yml' | ||||||||
| push: | ||||||||
| branches: [main] | ||||||||
| paths: | ||||||||
| - 'android-kotlin/**' | ||||||||
| - '.github/workflows/android-kotlin-browserstack.yml' | ||||||||
| workflow_dispatch: # Allow manual trigger | ||||||||
|
|
||||||||
| concurrency: | ||||||||
| group: ${{ github.workflow }}-${{ github.ref }} | ||||||||
| cancel-in-progress: true | ||||||||
|
|
||||||||
| jobs: | ||||||||
| build-and-test: | ||||||||
| name: Build and Test on BrowserStack | ||||||||
| runs-on: ubuntu-latest | ||||||||
|
|
||||||||
| steps: | ||||||||
| - name: Checkout code | ||||||||
| uses: actions/checkout@v4 | ||||||||
|
|
||||||||
| - name: Set up JDK 17 | ||||||||
| uses: actions/setup-java@v4 | ||||||||
| with: | ||||||||
| java-version: '17' | ||||||||
| distribution: 'temurin' | ||||||||
|
|
||||||||
| - name: Setup Android SDK | ||||||||
| uses: android-actions/setup-android@v3 | ||||||||
|
|
||||||||
| - name: Setup Gradle | ||||||||
| uses: gradle/actions/setup-gradle@v3 | ||||||||
|
|
||||||||
| - name: Create .env file | ||||||||
| run: | | ||||||||
| echo "DITTO_APP_ID=${{ secrets.DITTO_APP_ID }}" > .env | ||||||||
| echo "DITTO_PLAYGROUND_TOKEN=${{ secrets.DITTO_PLAYGROUND_TOKEN }}" >> .env | ||||||||
| echo "DITTO_AUTH_URL=${{ secrets.DITTO_AUTH_URL }}" >> .env | ||||||||
| echo "DITTO_WEBSOCKET_URL=${{ secrets.DITTO_WEBSOCKET_URL }}" >> .env | ||||||||
|
|
||||||||
| - name: Cache Gradle dependencies | ||||||||
| uses: actions/cache@v4 | ||||||||
| with: | ||||||||
| path: | | ||||||||
| ~/.gradle/caches | ||||||||
| ~/.gradle/wrapper | ||||||||
| key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*', '**/gradle-wrapper.properties') }} | ||||||||
| restore-keys: | | ||||||||
| ${{ runner.os }}-gradle- | ||||||||
|
|
||||||||
| - name: Build APK | ||||||||
| working-directory: android-kotlin/QuickStartTasks | ||||||||
| run: | | ||||||||
| ./gradlew assembleDebug assembleDebugAndroidTest | ||||||||
| echo "APK built successfully" | ||||||||
|
|
||||||||
| - name: Run Unit Tests | ||||||||
| working-directory: android-kotlin/QuickStartTasks | ||||||||
| run: ./gradlew test | ||||||||
|
|
||||||||
| - name: Upload APKs to BrowserStack | ||||||||
| id: upload | ||||||||
| run: | | ||||||||
| CREDS="${{ secrets.BROWSERSTACK_USERNAME }}:${{ secrets.BROWSERSTACK_ACCESS_KEY }}" | ||||||||
|
|
||||||||
| # 1. Upload AUT (app-debug.apk) | ||||||||
| APP_UPLOAD_RESPONSE=$(curl -u "$CREDS" \ | ||||||||
| -X POST "https://api-cloud.browserstack.com/app-automate/espresso/v2/app" \ | ||||||||
| -F "file=@android-kotlin/QuickStartTasks/app/build/outputs/apk/debug/app-debug.apk" \ | ||||||||
| -F "custom_id=ditto-android-kotlin-app") | ||||||||
| APP_URL=$(echo "$APP_UPLOAD_RESPONSE" | jq -r .app_url) | ||||||||
| echo "app_url=$APP_URL" >> "$GITHUB_OUTPUT" | ||||||||
|
|
||||||||
| # 2. Upload Espresso test-suite (app-debug-androidTest.apk) | ||||||||
| TEST_UPLOAD_RESPONSE=$(curl -u "$CREDS" \ | ||||||||
| -X POST "https://api-cloud.browserstack.com/app-automate/espresso/v2/test-suite" \ | ||||||||
| -F "file=@android-kotlin/QuickStartTasks/app/build/outputs/apk/androidTest/debug/app-debug-androidTest.apk" \ | ||||||||
| -F "custom_id=ditto-android-kotlin-test") | ||||||||
| TEST_URL=$(echo "$TEST_UPLOAD_RESPONSE" | jq -r .test_suite_url) | ||||||||
| echo "test_url=$TEST_URL" >> "$GITHUB_OUTPUT" | ||||||||
|
|
||||||||
| - name: Execute tests on BrowserStack | ||||||||
| id: test | ||||||||
| run: | | ||||||||
| # Validate inputs before creating test execution request | ||||||||
| APP_URL="${{ steps.upload.outputs.app_url }}" | ||||||||
| TEST_URL="${{ steps.upload.outputs.test_url }}" | ||||||||
|
|
||||||||
| echo "App URL: $APP_URL" | ||||||||
| echo "Test URL: $TEST_URL" | ||||||||
|
|
||||||||
| if [ -z "$APP_URL" ] || [ "$APP_URL" = "null" ]; then | ||||||||
| echo "Error: No valid app URL available" | ||||||||
| exit 1 | ||||||||
| fi | ||||||||
|
|
||||||||
| if [ -z "$TEST_URL" ] || [ "$TEST_URL" = "null" ]; then | ||||||||
| echo "Error: No valid test URL available" | ||||||||
| exit 1 | ||||||||
| fi | ||||||||
|
|
||||||||
| # Create test execution request | ||||||||
| BUILD_RESPONSE=$(curl -u "${{ secrets.BROWSERSTACK_USERNAME }}:${{ secrets.BROWSERSTACK_ACCESS_KEY }}" \ | ||||||||
| -X POST "https://api-cloud.browserstack.com/app-automate/espresso/v2/build" \ | ||||||||
| -H "Content-Type: application/json" \ | ||||||||
| -d "{ | ||||||||
| \"app\": \"$APP_URL\", | ||||||||
| \"testSuite\": \"$TEST_URL\", | ||||||||
| \"devices\": [ | ||||||||
| \"Google Pixel 8-14.0\", | ||||||||
| \"Samsung Galaxy S23-13.0\", | ||||||||
| \"Google Pixel 6-12.0\", | ||||||||
| \"OnePlus 9-11.0\" | ||||||||
| ], | ||||||||
| \"project\": \"Ditto Android Kotlin\", | ||||||||
| \"buildName\": \"Build #${{ github.run_number }}\", | ||||||||
| \"buildTag\": \"${{ github.ref_name }}\", | ||||||||
| \"deviceLogs\": true, | ||||||||
| \"video\": true, | ||||||||
| \"networkLogs\": true, | ||||||||
| \"autoGrantPermissions\": true | ||||||||
| }") | ||||||||
|
|
||||||||
| echo "BrowserStack API Response:" | ||||||||
| echo "$BUILD_RESPONSE" | ||||||||
|
|
||||||||
| BUILD_ID=$(echo "$BUILD_RESPONSE" | jq -r .build_id) | ||||||||
|
|
||||||||
| # Check if BUILD_ID is null or empty | ||||||||
| if [ "$BUILD_ID" = "null" ] || [ -z "$BUILD_ID" ]; then | ||||||||
| echo "Error: Failed to create BrowserStack build" | ||||||||
| echo "Response: $BUILD_RESPONSE" | ||||||||
| exit 1 | ||||||||
| fi | ||||||||
|
|
||||||||
| echo "build_id=$BUILD_ID" >> $GITHUB_OUTPUT | ||||||||
| echo "Build started with ID: $BUILD_ID" | ||||||||
|
|
||||||||
| - name: Wait for BrowserStack tests to complete | ||||||||
| run: | | ||||||||
| BUILD_ID="${{ steps.test.outputs.build_id }}" | ||||||||
|
|
||||||||
| # Validate BUILD_ID before proceeding | ||||||||
| if [ "$BUILD_ID" = "null" ] || [ -z "$BUILD_ID" ]; then | ||||||||
| echo "Error: No valid BUILD_ID available. Skipping test monitoring." | ||||||||
| exit 1 | ||||||||
| fi | ||||||||
|
|
||||||||
| MAX_WAIT_TIME=1800 # 30 minutes | ||||||||
|
||||||||
| MAX_WAIT_TIME=1800 # 30 minutes | |
| # Allow override of max wait time via env var, default to 900 seconds (15 minutes) | |
| MAX_WAIT_TIME="${BROWSERSTACK_MAX_WAIT_TIME:-900}" |
24 changes: 0 additions & 24 deletions
24
...tartTasks/app/src/androidTest/java/live/ditto/quickstart/tasks/ExampleInstrumentedTest.kt
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The curl commands for uploading APKs lack proper error handling. If the upload fails, the script continues with null URLs, leading to confusing error messages later. Add immediate validation of the upload responses.