Skip to content

feat: add support for invoice_numbers in payment response #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovrocolic merged 2 commits into from
Mar 12, 2026
Merged

feat: add support for invoice_numbers in payment response #381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c4d9b0
add support for invoice_numbers in payment response
lovrocolic Mar 12, 2026
e936adc
fix fixtures
lovrocolic Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lago_python_client/models/payment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class Payment(BaseModel):
class PaymentResponse(BaseResponseModel):
lago_id: str
invoice_ids: List[str]
invoice_numbers: List[str]
amount_cents: int
amount_currency: str
payment_status: str
Expand Down
1 change: 1 addition & 0 deletions tests/fixtures/payment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"payment": {
"lago_id": "8e5d5ec2-bdc7-4c43-a944-5ababae775d4",
"invoice_ids": ["f8e194df-5d90-4382-b146-c881d2c67f28"],
"invoice_numbers": ["LAG-1234-567-890"],
"amount_cents": 100,
"amount_currency": "USD",
"payment_status": "succeeded",
Expand Down
3 changes: 3 additions & 0 deletions tests/fixtures/payment_index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
"invoice_ids": [
"ed267c66-8170-4d23-83e8-6d6e4fc735ef"
],
"invoice_numbers": [
"LAG-1234-567-891"
],
"amount_cents": 100,
"amount_currency": "USD",
"payment_status": "succeeded",
Expand Down
3 changes: 3 additions & 0 deletions tests/fixtures/payment_receipt.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"invoice_ids": [
"ed267c66-8170-4d23-83e8-6d6e4fc735ef"
],
"invoice_numbers": [
"LAG-1234-567-891"
],
"amount_cents": 100,
"amount_currency": "USD",
"payment_status": "succeeded",
Expand Down
3 changes: 3 additions & 0 deletions tests/fixtures/payment_receipt_index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
"invoice_ids": [
"ed267c66-8170-4d23-83e8-6d6e4fc735ef"
],
"invoice_numbers": [
"LAG-1234-567-891"
],
"amount_cents": 100,
"amount_currency": "USD",
"payment_status": "succeeded",
Expand Down
2 changes: 2 additions & 0 deletions tests/test_payment_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ def test_valid_create_payment_request(httpx_mock: HTTPXMock):
assert response.payment_status == "succeeded"
assert len(response.invoice_ids) == 1
assert response.invoice_ids[0] == "f8e194df-5d90-4382-b146-c881d2c67f28"
assert len(response.invoice_numbers) == 1
assert response.invoice_numbers[0] == "LAG-1234-567-890"


def test_invalid_create_payment_request(httpx_mock: HTTPXMock):
Expand Down
Loading