fix(#648): fixes xforms-value-changed firing when editing submission#649
Open
garethbowen wants to merge 1 commit intomainfrom
Open
fix(#648): fixes xforms-value-changed firing when editing submission#649garethbowen wants to merge 1 commit intomainfrom
garethbowen wants to merge 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: c429397 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
garethbowen
commented
Feb 12, 2026
Comment on lines
+80
to
+89
| const instanceFile = new File([options.editInstance], INSTANCE_FILE_NAME, { | ||
| type: INSTANCE_FILE_TYPE, | ||
| }); | ||
| const instanceData = new FormData(); | ||
| instanceData.set(INSTANCE_FILE_NAME, instanceFile); | ||
| const instance = { | ||
| inputType: 'FORM_INSTANCE_INPUT_RESOLVED' as ResolvedFormInstanceInputType, | ||
| data: [instanceData as InstanceData] as const, | ||
| }; | ||
| return editInstance(formResource, instance, initOptions); |
Collaborator
Author
There was a problem hiding this comment.
This was a refactor to make it easier to test edits - now you just pass in the xml string.
garethbowen
commented
Feb 12, 2026
| action.computation.expression, | ||
| point | ||
| ); | ||
| setRelevantValue(point); |
Collaborator
Author
There was a problem hiding this comment.
This was another refactor which simplifies the code quite a bit, but would appreciate your take as you're familiar with the geopoint code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #648
I have verified this PR works in these browsers (latest versions):
What else has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Do we need any specific form for testing your changes? If so, please attach one.
What's changed