feat: Count special attachment items as error#5919
Conversation
| if self.creates_event() { | ||
| // for minidumps, etc. | ||
| quantities.push((DataCategory::Error, 1)); | ||
| } | ||
| quantities |
There was a problem hiding this comment.
The problem with this is, if an envelope has two items which creates_event(), this will be wrong again :(.
There was a problem hiding this comment.
But an envelope like that would get rejected anyway, right? My idea was: count an error for the item (a sensible default IMO), then manually fix the cases where this causes a mismatch.
There was a problem hiding this comment.
I think you can have a minidump and an error in the same envelope, each item individually counts as an error, but combined in an envelope it's just a single one.
There was a problem hiding this comment.
Fair enough, I think I made the mistake of editing Item::quantities directly.
What I actually want is that a Managed<Item> containing a minidump reports error: 1, so that this affects only the few cases where we construct an envelope from individual managed items. Let's discuss on Monday.
2 participants
Experiment for #5918