fix(tracing): add system prompt, model to google genai #18424
+170
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacs
added a commit
that referenced
this pull request
Dec 8, 2025
isaacs
force-pushed
the
isaacschlueter/js-1218-js-google-genai-response-model-missing
branch
from
c076192 to
ff94aff
Compare
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
isaacs
added a commit
that referenced
this pull request
Dec 8, 2025
isaacs
force-pushed
the
isaacschlueter/js-1218-js-google-genai-response-model-missing
branch
from
ff94aff to
75f40f5
Compare
|
|
||
| span.setAttributes({ | ||
| [GEN_AI_REQUEST_MESSAGES_ATTRIBUTE]: JSON.stringify(truncateGenAiMessages(messages)), | ||
| [GEN_AI_RESPONSE_MODEL_ATTRIBUTE]: String(params.model), |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
isaacs
added a commit
that referenced
this pull request
Dec 8, 2025
isaacs
force-pushed
the
isaacschlueter/js-1218-js-google-genai-response-model-missing
branch
from
75f40f5 to
63be4b7
Compare
isaacs
added a commit
that referenced
this pull request
Dec 8, 2025
isaacs
force-pushed
the
isaacschlueter/js-1218-js-google-genai-response-model-missing
branch
from
63be4b7 to
0a5ed6e
Compare
Comment on lines
156
to
160
| if (Array.isArray(params.contents)) { | ||
| messages.push(...params.contents); | ||
| } else { | ||
| messages.push({ role: 'user', content: params.contents }); | ||
| } |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| span.setAttributes({ [GEN_AI_REQUEST_MESSAGES_ATTRIBUTE]: truncatedMessage }); | ||
| if (Array.isArray(params.message)) { | ||
| messages.push(...params.message); | ||
| } else { |
There was a problem hiding this comment.
Bug: Part arrays incorrectly spread as individual messages
When params.message is Part[] (array of parts for a single user message), the code spreads each Part object as a separate item in the messages array. However, Part objects like { text: "hello" } don't have content: string or parts: Array properties required by the truncation logic in truncateGenAiMessages. When truncation is needed, these Part objects fail both isContentMessage and isPartsMessage checks, causing truncateSingleMessage to return an empty array and silently drop the data. The Part[] should instead be wrapped as { role: 'user', parts: params.message } to match the Google GenAI Content format. The same issue affects contents when it's PartUnion[].
Additional Locations (1)
nicohrubec
reviewed
Dec 9, 2025
isaacs
added a commit
that referenced
this pull request
Dec 9, 2025
Move the message reformatting into a separate util for google-genai, and add unit test coverage for that file. Add an integration test scenario to ensure that the system message will be included if provided in the config params. Related to getsentry/testing-ai-sdk-integrations#10 Fix JS-1218
isaacs
force-pushed
the
isaacschlueter/js-1218-js-google-genai-response-model-missing
branch
from
0a5ed6e to
cd250d2
Compare
isaacs
added a commit
that referenced
this pull request
Dec 9, 2025
Move the message reformatting into a separate util for google-genai, and add unit test coverage for that file. Add an integration test scenario to ensure that the system message will be included if provided in the config params. Related to getsentry/testing-ai-sdk-integrations#10 Fix JS-1218
isaacs
force-pushed
the
isaacschlueter/js-1218-js-google-genai-response-model-missing
branch
from
cd250d2 to
47e85eb
Compare
Move the message reformatting into a separate util for google-genai, and add unit test coverage for that file. Add an integration test scenario to ensure that the system message will be included if provided in the config params. Related to getsentry/testing-ai-sdk-integrations#10 Fix JS-1218
isaacs
force-pushed
the
isaacschlueter/js-1218-js-google-genai-response-model-missing
branch
from
47e85eb to
e2a9837
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/getsentry/testing-ai-sdk-integrations/pull/10
Fix JS-1218