Skip to content

ref(spotlight): Pass int curl timeouts in SpotlightClient to drop PHPStan baseline entry - #2392

Merged
Litarnus merged 1 commit into
masterfrom
ref/spotlight-int-curl-timeouts
Nov 18, 2026
Merged

Litarnus merged 1 commit into
masterfrom
ref/spotlight-int-curl-timeouts

Conversation

@sentry-junior

@sentry-junior sentry-junior Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Removes this PHPStan baseline entry:

  • src/Spotlight/SpotlightClient.php: Parameter #3 $value of function curl_setopt expects int, float given. (count 2)

CURLOPT_TIMEOUT and CURLOPT_CONNECTTIMEOUT take integer seconds. SpotlightClient passed the float literals 2.0 and 1.0; they are now 2 and 1.

Nothing breaks: curl already coerces these values to int, so the effective timeouts (2s total, 1s connect) stay the same.

via automation sched_a59acc45df166a80a839d0b32321e740 · Run ID sched_a59acc45df166a80a839d0b32321e740:1794992400000.

--

View Session [Sentry]

@Litarnus
Litarnus marked this pull request as ready for review November 18, 2026 09:58
@Litarnus
Litarnus requested review from a team and stayallive as code owners November 18, 2026 09:58
@Litarnus
Litarnus merged commit d60d4c5 into master Nov 18, 2026
59 checks passed
@Litarnus
Litarnus deleted the ref/spotlight-int-curl-timeouts branch November 18, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant