Skip to content

falcond: Work on other CPUS#8643

Merged
EbonJaeger merged 1 commit intogetsolus:mainfrom
uni-dos:falcond-fix
Apr 25, 2026
Merged

falcond: Work on other CPUS#8643
EbonJaeger merged 1 commit intogetsolus:mainfrom
uni-dos:falcond-fix

Conversation

@uni-dos
Copy link
Copy Markdown
Contributor

@uni-dos uni-dos commented Apr 24, 2026

Summary

  • add flag allowing different cpus to work

Test Plan

Do not know how to test as all my devices run an AMD CPU

Checklist

  • Package was built and tested against unstable
  • This change could gainfully be listed in the weekly sync notes once merged

Resolves #8642

Copy link
Copy Markdown
Contributor

@TraceyC77 TraceyC77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've marked this as NFC but it does contain a functional change due to the build flag addition. Please update this to reflect that.

Also, please get someone with appropriate hardware to test.

Comment thread packages/f/falcond/package.yml
@uni-dos uni-dos changed the title [NFC] falcond: Work on other CPUS falcond: Work on other CPUS Apr 24, 2026
@uni-dos uni-dos marked this pull request as draft April 24, 2026 16:47
**Summary**
- add flag allowing different cpus to work
@uni-dos
Copy link
Copy Markdown
Contributor Author

uni-dos commented Apr 24, 2026

How exactly would someone be able to test it? If the issue was that the package was built for the architecture of the build server/AMD and they build it on say an Intel system it will work because it was build from source.

@TraceyC77
Copy link
Copy Markdown
Contributor

How exactly would someone be able to test it? If the issue was that the package was built for the architecture of the build server/AMD and they build it on say an Intel system it will work because it was build from source.

Can you walk me through exactly what this build flag allows, in detail?

@uni-dos
Copy link
Copy Markdown
Contributor Author

uni-dos commented Apr 24, 2026

I am not entirely sure. I would assume that it builds a falcond as just a generic x86_64 binary instead of either an amd or intel specific one. That flag was what the dev suggested.

@EbonJaeger
Copy link
Copy Markdown
Member

Intel user tested this change with a package I built with an AMD system. Seems to work.

@uni-dos uni-dos marked this pull request as ready for review April 25, 2026 00:03
Copy link
Copy Markdown
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@EbonJaeger EbonJaeger dismissed TraceyC77’s stale review April 25, 2026 15:08

Review items addressed

@EbonJaeger EbonJaeger merged commit 11bf99a into getsolus:main Apr 25, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from Triage to Done in Solus Apr 25, 2026
@uni-dos uni-dos deleted the falcond-fix branch April 25, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

falcond: Only built for one CPU arch

3 participants