Migrate remaining XCTest tests to Swift Testing#260
Open
giginet wants to merge 5 commits into
Open
Conversation
- Replace XCTestCase with @suite(.serialized) struct - Add descriptive test descriptions using @test macro - Use TemporaryDirectoryTrait for temp directory management - Replace XCTAssertEqual/XCTAssertNil with #expect - Replace do-catch with XCTFail with #expect(throws:) - Modernize URL APIs (filePath, appending(components:)) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Convert the standalone function to a static method on an enum for better namespace organization and discoverability. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ikesyo
reviewed
May 6, 2026
Comment on lines
-848
to
-858
| override func tearDownWithError() throws { | ||
| try removeIfExist(at: testPackagePath.appendingPathComponent(".build")) | ||
| try removeIfExist(at: frameworkOutputDir) | ||
| try super.tearDownWithError() | ||
| } | ||
|
|
||
| private func removeIfExist(at path: URL) throws { | ||
| if fileManager.fileExists(atPath: path.path) { | ||
| try self.fileManager.removeItem(at: path) | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
I think the cleanup should be kept.
Comment on lines
+209
to
211
| await #expect(throws: CacheSystem.Error.self) { | ||
| _ = try await cacheSystem.calculateCacheKey(of: cacheTarget) | ||
| XCTFail("A cache key should not be possible to calculate if the package is not in a repository.") | ||
| } catch let error as CacheSystem.Error { | ||
| XCTAssertEqual(error.errorDescription, "Repository version is not detected for \(descriptionPackage.name).") | ||
| } catch { | ||
| XCTFail("Wrong error type.") | ||
| } |
Collaborator
There was a problem hiding this comment.
The test should validate the actual error description as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation & Context
Continuing the migration from XCTest to Swift Testing framework. This PR completes the migration of remaining test files that were still using XCTest.
Description
CacheSystemTests,RunnerTests, andIntegrationTeststo Swift TestingXCTestCaseclasses to@Suite(.serialized)structsXCTAssertEqual/XCTAssertTrue/XCTAssertFalsewith#expectXCTSkipUnlesswith.enabled(if:)traitaddTeardownBlockwithdeferdetectFrameworkTypefunction toFrameworkTypeDetector.detectstatic method