fix(plugins): namespace Copilot materialized content - #2643
Merged
Conversation
Place Copilot-specific content in com.github.copilot and remove unsupported command handling. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 04c14c3f-d248-4a7f-93ab-93fd8b2b119e
Contributor
There was a problem hiding this comment.
Pull request overview
Namespaces Copilot-specific plugin content while retaining portable skills at the plugin root.
Changes:
- Moves agents, hooks, and extensions under
com.github.copilot/. - Updates cleanup to reconstruct source composition metadata.
- Removes unsupported command handling and updates documentation.
Show a summary per file
| File | Description |
|---|---|
eng/validate-plugins.mjs |
Removes command validation. |
eng/update-readme.mjs |
Removes commands from item counts. |
eng/materialize-plugins.mjs |
Materializes Copilot-specific content under its namespace. |
eng/generate-website-data.mjs |
Removes commands from website plugin items. |
eng/clean-materialized-plugins.mjs |
Restores namespaced materialized content. |
CONTRIBUTING.md |
Updates plugin authoring guidance. |
AGENTS.md |
Updates repository plugin documentation. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Suppressed comments (1)
eng/update-readme.mjs:873
- The featured-plugin count has the same omission as the main plugin table: supported hooks and resolved MCP servers are excluded, so featured counts can disagree with website data. Reuse the corrected item-count helper here rather than maintaining a second incomplete formula.
const itemCount =
(composition.agents || []).length +
(composition.skills || []).length +
extensionReferences +
implicitExtension;
- Files reviewed: 7/7 changed files
- Comments generated: 4
- Review effort level: Balanced
Comment on lines
+32
to
+38
| extensions: { | ||
| paths: [path.join(COPILOT_CONTENT_DIR, "extensions"), "extensions"], | ||
| restore(dirPath) { | ||
| return collectDirectoriesContainingFile(dirPath, "extension.mjs") | ||
| .map((relativePath) => `./extensions/${relativePath}`); | ||
| }, | ||
| }, |
Comment on lines
+621
to
626
| // Build items list from supported composition fields. | ||
| const items = [ | ||
| ...agentItems, | ||
| ...(composition.commands || []).map((p) => ({ kind: "prompt", path: p })), | ||
| ...(composition.skills || []).map((p) => ({ kind: "skill", path: p })), | ||
| ...extensionItems, | ||
| ...mcpItems, |
Comment on lines
801
to
805
| const itemCount = | ||
| (composition.agents || []).length + | ||
| (composition.commands || []).length + | ||
| (composition.skills || []).length + | ||
| extensionReferences + | ||
| implicitExtension; |
Comment on lines
+217
to
219
| const compositionFields = ["agents", "hooks", "mcpServers", "skills"]; | ||
| const extensions = plugin.extensions; | ||
| const composition = extensions?.[AWESOME_COPILOT_NAMESPACE]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
npm startand verified thatREADME.mdis up to date.mainbranch for this pull request.Description
Agent Plugins 1.0 requires client-specific content to live under
com.github.copilot/. Materialization now places agents, hooks, and canvas extensions there while retaining portable skills underskills/.The cleanup flow restores the source composition namespace from the namespaced layout, and all unsupported
commandshandling has been removed from materialization, validation, generated item counts, and contributor guidance.Type of Contribution
Additional Notes
nodeandnpmare unavailable in the execution environment, so the repository JavaScript validation commands could not be run.By submitting this pull request, I confirm that my contribution abides by the Code of Conduct and will be licensed under the MIT License.