route npm package pulls through the public cfs proxy - #496
Closed
brandonganem wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Routes npm dependency restores through the public CFS proxy while allowing centrally managed CI overrides.
Changes:
- Sets the public CFS proxy as the local npm registry.
- Configures all npm-installing workflows with an override and public fallback.
- Preserves lockfile and bundled artifacts.
Show a summary per file
| File | Description |
|---|---|
.npmrc |
Sets the default npm registry proxy. |
.github/workflows/test.yml |
Configures the test registry. |
.github/workflows/release.yml |
Configures the release registry. |
.github/workflows/package-check.yml |
Configures the package-check registry. |
.github/workflows/lint.yml |
Configures the lint registry. |
.github/workflows/copilot-setup-steps.yml |
Configures the setup registry. |
.github/workflows/acceptance.yml |
Configures the acceptance registry. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 7/7 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repository package restores now use the public CFS npm proxy while Actions retain a centrally managed registry override with a safe public fallback.
What
vars.CFS_NPM_REGISTRYand the public fallback.Why
Centralizing package pulls gives the repository a consistent CFS route without rewriting lockfile tarball hosts or enabling the incompatible
NPM_CONFIG_REPLACE_REGISTRY_HOST=alwayssetting.Validation
npm ci --ignore-scripts --no-audit --no-fundcompleted through the public CFS proxy and leftpackage-lock.jsonunchanged.npm run format-check, both TypeScript checks, the policy lint, YAML parsing, andnpm run packagepassed; the bundle reproduced exactly.