Skip to content

Go: move extractor smoke test into integration tests #22371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
redsun82 merged 1 commit into from
Aug 18, 2026
Merged

Go: move extractor smoke test into integration tests #22371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
/go/codeql-tools/ @github/codeql-go @github/code-scanning-language-coverage
/go/downgrades/ @github/codeql-go @github/code-scanning-language-coverage
/go/extractor/ @github/codeql-go @github/code-scanning-language-coverage
/go/extractor-smoke-test/ @github/codeql-go @github/code-scanning-language-coverage
/go/ql/test/extractor-tests/ @github/codeql-go @github/code-scanning-language-coverage
/java/ @github/codeql-java
/javascript/ @github/codeql-javascript
Expand Down
1 change: 0 additions & 1 deletion go/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ test: all build/testdb/check-upgrade-path
# use GOOS=linux because GOOS=darwin GOARCH=386 is no longer supported
env GOOS=linux GOARCH=386 codeql$(EXE) test run -j0 ql/test/query-tests/Security/CWE-681 --search-path .. --check-diff-informed --consistency-queries ql/consistency-queries --compilation-cache=$(cache) --dynamic-join-order-mode=$(rtjo)
cd extractor; $(BAZEL) test ...
bash extractor-smoke-test/test.sh || (echo "Extractor smoke test FAILED"; exit 1)

.PHONY: build/testdb/check-upgrade-path
build/testdb/check-upgrade-path : build/testdb/go.dbscheme ql/lib/go.dbscheme
Expand Down
4 changes: 0 additions & 4 deletions go/extractor-smoke-test/.gitignore
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions go/extractor-smoke-test/expected.csv
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions go/extractor-smoke-test/go.mod
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions go/extractor-smoke-test/main.go
View file
Open in desktop

This file was deleted.

26 changes: 0 additions & 26 deletions go/extractor-smoke-test/test.sh
View file
Open in desktop

This file was deleted.

9 changes: 9 additions & 0 deletions go/ql/integration-tests/test-extraction/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,12 @@ def test_traced(codeql, go):

def test_autobuild(codeql, go):
codeql.database.create(source_root="src", extractor_option = ["extract_tests=true"])

def test_autobuild_traced(codeql, go):
# Autobuild under build tracing must produce the same database as untraced
# autobuild and explicit traced builds, all checked against test.expected.
codeql.database.create(
source_root="src",
extractor_option = ["extract_tests=true"],
_env={"CODEQL_EXTRACTOR_GO_BUILD_TRACING": "on"},
)
Loading