On branch edburns/1146-support-three-more-permission-kind-values — Fixes #1146: bump test harness CLI to support new permission protocol#1150
Open
edburns wants to merge 2 commits intogithub:mainfrom
Conversation
github#1146: bump test harness CLI to support new permission protocol Changes to be committed: (use "git restore --staged <file>..." to unstage) modified: .gitignore new file: test/harness/cliCompatibility.test.ts - New regression test validating the harness CLI supports the current SDK permission protocol (`approve-once`, `reject`, `user-not-available`) and per-session auth (`auth.getStatus`, `gitHubToken`). modified: test/harness/package-lock.json - Regenerated lockfile; resolves `@github/copilot` to 1.0.36. modified: test/harness/package.json - Bumped `@github/copilot` from `^1.0.32` to `^1.0.36-0` so the harness CLI accepts the new `PermissionDecision` wire values and `session.auth.getStatus` RPC method introduced in commit `dd2dcbc`.
Contributor
|
@edburns Did you definitely observe that this makes a difference to the existing E2E tests in this repo? In my understanding, the changes here won't have any effect, since the version of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to be committed:
(use "git restore --staged ..." to unstage)
modified: .gitignore
new file: test/harness/cliCompatibility.test.ts
- New regression test validating the harness CLI supports the current SDK permission protocol (
approve-once,reject,user-not-available) and per-session auth (auth.getStatus,gitHubToken).modified: test/harness/package-lock.json
- Regenerated lockfile; resolves
@github/copilotto 1.0.36.modified: test/harness/package.json
- Bumped
@github/copilotfrom^1.0.32to^1.0.36-0so the harness CLI accepts the newPermissionDecisionwire values andsession.auth.getStatusRPC method introduced in commitdd2dcbc.All 5 failures are pre-existing flaky tests unrelated to this PR's changes (which only touch package.json, package-lock.json, and add cliCompatibility.test.ts). The last 5 runs on
mainfor each workflow are all green.test/client.test.ts > CopilotClient > forwards defaultAgent in session.resume requestNo authentication info available— auth race in test setupMultiClientTests.One_Client_Rejects_Permission_And_Both_See_The_ResultToolExecutionCompleteEventbefore expected sequenceTestSessionFs/should_write_workspace_metadata_via_sessionFsReplayingCapiProxy not yet initialized— proxy/test init raceEvidence these are pre-existing:
forwards defaultAgent in session.resumetest also failed in the first CI run (before the lockfile fix), confirming it's not caused by the CLI version bump..NET SDK Testsruns onmainall passed (#1220, #1214, #1198, #1195, #1194).Go SDK Testsruns onmainall passed similarly.52f187fand those platforms now pass for .NET and Go.Requesting re-run of failed jobs.