Fix README claim that the gateway config section is optional - #11296
Conversation
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
gateway config section is optional
There was a problem hiding this comment.
Pull request overview
Corrects README guidance to match JSON stdin schema validation.
Changes:
- Documents required
gatewayfields. - Clarifies the deprecated
apiKeyalias.
Show a summary per file
| File | Description |
|---|---|
| README.md | Corrects JSON stdin configuration requirements. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
🔒 mcpg Read-Only Stress — gVisorSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Overall: PASS Full ReportPart A — MCP Reads (ALLOWED ✅)
Part B — MCP Writes (BLOCKED ✅)Gateway exposes only 22 read-only tools. All write tool calls return
No writes succeeded. No issue/branch/PR/comment/reaction was created. Part C — CLI Reads (ALLOWED ✅)
Part D — CLI REST Writes (BLOCKED ✅)
Part E — GraphQL Mutations (BLOCKED ✅)
References: §31918762540
|
🔒 mcpg Read-Only Stress — docker-sbxSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Overall: PASS
|
🔒 mcpg Read-Only Stress — default AWFSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Overall: PASS Full ReportPart A — MCP reads: All 4 returned data with ~530ms latency (confirming real backend hits).
Part B — MCP writes: All 7 blocked by the gateway in 6–10 ms (vs ~530 ms for real backend calls), confirming the gateway's tool allow-list refuses write operations before any request reaches the GitHub backend. Error:
Part C — CLI reads: The Part D — CLI REST writes: Part E — GraphQL mutations: Run: §31918762539
|
The Quick Start note in
README.mdstated that thegatewaysection and all of its fields are optional and that "omittinggatewayentirely is valid and uses built-in defaults." The embedded JSON schema requires the opposite, so users following the note hit a validation error at startup.Changes
README.md:34— replaced the "optional / built-in defaults" note with an accurate statement: for JSON stdin config,gatewayis required and must containport,domain, and one ofagentId/apiKey(notingapiKeyis a deprecated alias). Remaininggatewayfields are documented as optional and validated when present. The server-field sentence is unchanged.Behavior this reflects
internal/config/schema/mcp-gateway-config.schema.jsondeclares"required": ["mcpServers", "gateway"],"required": ["port", "domain"]ongatewayConfig, and ananyOfrequiringagentIdorapiKey— matching the existing expectations ininternal/config/validation_schema_test.go.Documentation-only; no code paths touched. TOML config behavior was not changed or re-characterized here.