[log] Add debug logging to registerCoreFlags in internal/cmd/flags_core.go - #11468
Conversation
Log flag registration entry/exit using the existing shared debugLog logger (namespace cmd:root) to aid troubleshooting of CLI flag setup. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds debug visibility around core CLI flag registration.
Changes:
- Logs entry into
registerCoreFlags. - Logs completion after validation groups are configured.
Show a summary per file
| File | Description |
|---|---|
internal/cmd/flags_core.go |
Adds start and completion debug logs for core flag registration. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
🔒 mcpg Read-Only Stress — docker-sbxSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Overall: INCONCLUSIVE
No writes leaked. Run ID: 32197597360
|
Adds debug logging to
registerCoreFlagsininternal/cmd/flags_core.go.Changes
debugLoglogger in thecmdpackage (namespacecmd:root), no new logger declaration needed.registerCoreFlags.Validation
go build -o awmg .— succeedsgo vet ./internal/cmd/...— cleango test ./internal/cmd/...— passesDEBUG=cmd:* ./awmg --config nonexistent.toml --listen :0that both new log lines are emitted.Single-file, focused change per task constraints.