feat(comments): add typed visibility tool inputs and outputs

[SamMorrowDrums]

Summary

Migrate the shared hide/unhide comment-visibility factory to typed inputs and results for all six issue-comment, pull-request review-comment, and review tools. Supported negotiated MCP protocol 2026-07-28+ receives output schemas and structured results with matching JSON text; unknown protocol versions are treated as legacy, preserving exact legacy text.

Why

Dependent layer above #3377, using the typed registration and legacy normalization foundation from #3371. No issue is closed by this layer; #3360 remains unchanged and open.

What changed

• Add typed comment visibility inputs and a minimal concrete result while retaining exact target-dependent input metadata, identifiers, numeric minimums, permissions, and feature rules.
• Normalize legacy numeric-string IDs and classifier casing through the foundation hook before SDK validation; preserve ignored arguments and rejection semantics.
• Reuse the process-cached output schema for all six constructors through inventory.CachedSchemaFor.
• Add initialized-session wire tests for hide/unhide targets, legacy byte fixtures, modern text/structured parity, output conformance, errors, and gating; update only six related tool snapshots.

MCP impact

• No tool or API changes
• Tool schema or behavior changed
• New tool added
  Output schemas and typed structured content are added for supported modern clients. Unknown versions remain legacy; runtime support for unrecognized future versions is not expanded. Input schemas and legacy success text remain unchanged; errors never become structured success outputs.

Prompts tested (tool changes only)

• Mocked wire-call equivalents of “Hide issue comment 1 as off-topic”, “Unhide inline pull request review comment 2”, and “Hide/unhide review 3 on pull request 42”; these are automated protocol tests, not live GitHub prompt runs.

Security / limits

• No security or limits impact
• Auth / permissions considered
• Data exposure, filtering, or token/size limits considered
  Existing repo scope requirements, granular feature flags, read-only filtering, permission descriptions, and API calls are preserved. The concrete result contains only node ID and visibility fields; invalid inputs and failed mutations never yield successful structured output.

Tool renaming

• I am renaming tools as part of this PR (e.g. a part of a consolidation effort)
  • I have added the new tool aliases in deprecated_tool_aliases.go
• I am not renaming tools as part of this PR
  All six tool names are unchanged.

Note: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.

Lint & tests

• Linted locally with ./script/lint
• Tested locally with ./script/test
  On local committed HEAD 0da1567de7d56f4e8e5ae51a5c473a31f34b2888, rebased linearly onto context e493a9b9b33d26d909afaee1f236cbb830da4251, ran in order: script/lint passed (0 issues); script/test passed (full go test -race ./...); UPDATE_TOOLSNAPS=true go test ./... passed (owned snapshots unchanged); script/generate-docs passed (no generated documentation diff). git diff --check passed and final worktree is clean. Discarded only unrelated generator-produced trailing-newline drift in merge_pull_request.snap. Live PAT-dependent e2e tests were not run. This local revision awaits separate push authorization; these are local results, not fresh CI claims.

Docs

• Not needed
• Updated (README / docs / examples)
  Generated documentation is unchanged; protocol clarification is recorded here and alongside protocol tests. Six tool snapshots total 246 lines on main and 372 lines in this layer: hide/unhide issue comment 47/33 → 67/53; hide/unhide review comment 47/33 → 67/53; hide/unhide review 53/39 → 73/59. Input metadata is retained; additions describe the output API only.

[Copilot]

Copilot review overview

🟢 Approval recommended

The typed migration preserves existing contracts and is comprehensively covered across supported protocol versions and failure paths.

Review effort: Balanced
Findings: None

What changed in this PR

Migrates six comment-visibility tools to typed inputs and outputs while preserving legacy behavior and protocol-gating structured results.

Changes:

• Adds typed visibility inputs, output schemas, and normalized legacy arguments.
• Preserves feature, scope, read-only, and error behavior.
• Adds comprehensive protocol and behavior tests with updated snapshots.

File	Description
pkg/​github/​comment_minimize.go	Implements typed visibility tools and normalization.
pkg/​github/​comment_minimize_test.go	Tests schemas, protocols, gates, and errors.
pkg/​github/​__toolsnaps__/​hide_issue_comment.snap	Adds hide output schema.
pkg/​github/​__toolsnaps__/​unhide_issue_comment.snap	Adds unhide output schema.
pkg/​github/​__toolsnaps__/​hide_pull_request_review_comment.snap	Adds hide output schema.
pkg/​github/​__toolsnaps__/​unhide_pull_request_review_comment.snap	Adds unhide output schema.
pkg/​github/​__toolsnaps__/​hide_pull_request_review.snap	Adds hide output schema.
pkg/​github/​__toolsnaps__/​unhide_pull_request_review.snap	Adds unhide output schema.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

⚠️ License files need updating

The license files are out of date. I tried to fix them automatically but don't have permission to push to this branch.

Please run:

script/licenses
git add third-party-licenses.*.md third-party/
git commit -m "chore: regenerate license files"
git push

Alternatively, enable "Allow edits by maintainers" in the PR settings so I can fix it automatically.

[Copilot]

Copilot review overview

🟢 Approval recommended

The typed migration preserves the existing contracts and includes comprehensive protocol and validation coverage.

Review effort: Balanced
Findings: None

[Copilot]

Copilot review overview

🟡 Changes recommended

Schema inference is repeated in request-scoped constructors, and the documented future-protocol behavior conflicts with exact-version gating.

Review effort: Balanced
Findings: 1 · 1

Open (2)

• Typed output gating excludes future protocol versions · New
• Cache inferred schema before constructing request-scoped tools · New

[Copilot]

Copilot review overview

🟢 Approval recommended

The typed migration preserves compatibility and is thoroughly covered across all six tools and protocol eras.

Review effort: Balanced
Findings: None

Resolved since last review (2)

• Typed output gating excludes future protocol versions
• Cache inferred schema before constructing request-scoped tools